Remove 12 AgentManager passthrough methods - #622
Closed
selfcontained wants to merge 1 commit into
Closed
Conversation
Callers in mcp-handlers.ts and persona-reviews.ts already have pool access and can call the underlying modules (feedbackQueries, personaReviews, telemetry) directly. This eliminates the passthrough layer for those call sites and shrinks manager.ts by 130 lines. Eight passthroughs remain for callers in routes/mcp.ts and routes/feedback.ts that lack pool in their deps — those are deferred to the next tech-debt run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentManagerthat simply delegated tofeedbackQueries,personaReviews, andtelemetrymodules. Callers inmcp-handlers.tsandroutes/persona-reviews.tsalready havepoolaccess and now call these modules directly.routes/mcp.tsandroutes/feedback.tsthat lack pool in their deps — queued for the next tech-debt run.Removed methods:
createPersonaReview,updatePersonaReviewStatus,completePersonaReview,submitFeedback,listFeedbackByParentGrouped,updateFeedbackStatusByParent,countFeedbackForAgent,submitReviewResolution,getReviewResolutions,listResolvedFeedbackForRound,cancelReviewRecheck,listMediaNext run: Add pool to
routes/mcp.tsandroutes/feedback.tsdeps, then remove the remaining 8 passthroughs.Test plan
pnpm run check— TypeScript type checking passespnpm run test— all Vitest unit tests pass (1437 passed)pnpm run test:e2e— 118 passed, 1 pre-existing flake (agent-routing deep-link, unrelated)🤖 Generated with Claude Code