Split diff-annotations.tsx into one file per component - #855
Merged
Conversation
diff-annotations.tsx (551 lines) exported three unrelated inline diff annotation components. Each now lives in its own file: - diff-comment-form.tsx (InlineCommentForm) - diff-feedback-annotation.tsx (InlineFeedbackAnnotation) - diff-draft-annotation.tsx (InlineDraftAnnotation) - diff-annotation-style.ts (shared sticky width style) Pure structural move — no behavior or rendering changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
apps/web/src/components/app/diff-annotations.tsx(551 lines) bundled three unrelated inline diff annotation components in one file. This splits it into one file per exported component:diff-comment-form.tsx(180 lines) —InlineCommentFormdiff-feedback-annotation.tsx(229 lines) —InlineFeedbackAnnotationdiff-draft-annotation.tsx(148 lines) —InlineDraftAnnotationdiff-annotation-style.ts(3 lines) — sharedstickyAnnotationStyleconstantdiff-annotations.tsx— deletedWhy
Queued as
next_focusby the componentizer job: classic compound-component file that grew over time. The only consumer isunified-diff-view.tsx, whose import block now points at the three new files. Pure structural move — component bodies are byte-identical; no behavior or rendering changes.Validation
pnpm run finalize:webgreen (typecheck + production build)pnpm run test:e2egreen (175 passed, 12 skipped)Next up
browser-extension-settings.tsx(640 lines) — extract pairing flow into ause-extension-pairinghook + setup-instructions subcomponent.🤖 Generated with Claude Code