Docs: AUTHORING.md — manifest parser strips unknown fields, doesn't reject them - #869
Merged
Merged
Conversation
The migration-manifest section of AUTHORING.md claimed extra fields "will fail validation", but UpdateMigrationManifestSchema is a plain z.object — unknown keys are silently stripped, never rejected. Reword so authors don't rely on a validation error that never fires. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly docs audit (2026-08-02, scheduled job).
Audited this run
notification-settings.tsx+ split section components,notification-runtime.ts,focus-tracker.ts,use-agent-focus.ts,slack.ts,agent-lifecycle-tools.ts: all claims verified accurate (3s web-notify ack fallback, 15s heartbeat / 30s TTL focus suppression, 4 status cues + mobile tap, Tips & Guidance controls,dispatch_notifyparams/limits, persona agents lacking the tool).repo-tools.ts,mcp/server.tstool sets +toolsRoot,routes/mcp.tsscope,lifecycle-hooks.ts,setup-script.ts: all claims verified accurate (repo_ prefix, dot sanitization, param→flag mapping, effective agent/job scopes, stop hook 15s best-effort,DISPATCH_AGENT_ID,~/.dispatch/env).Changed
release-notes/AUTHORING.md: the migration-manifest section claimed fields outside the V1 schema "will fail validation".UpdateMigrationManifestSchemais a plainz.object— unknown keys are silently stripped, never rejected — and nothing else (bin scripts, CI) validates manifests strictly. Reworded so authors don't rely on an error that never fires.Deferred / noted
update-migrations.ts/update-migrations-evaluator.ts/assisted-update.ts).apps/server/src/shared/git/worktree.tsafter the Consolidate duplicated git helpers into shared git-context #867 git-context consolidation.🤖 Generated with Claude Code