Correct the Media & Sharing docs and cover the guidance trim - #969
Merged
Conversation
Media & Sharing deep-dive. Most of the section verified clean as sets in both directions — the four sidebar tabs against MediaSidebarTab, the eight pin types, dispatch_share's formats/32KB cap/simulator/update semantics, the five list_media sources, the most-recent-50 limit, MJPEG-over-CDP streaming, and the eight-pin group auto-collapse. What had drifted: - The Reviews tab was described as "human review feedback submitted from the Changes tab". It shows persona reviewer submissions too (reviewerType "agent" from dispatch_review_submit), which is the more common case. The claimed three-value badge set was also wrong: reviews-sidebar-row maps partially_resolved to the "Open" label, so only Open and Resolved ever render. Rewritten around what the row actually shows, including the resolved count and the "Approved · no feedback" state. - Lightbox previews never mentioned the Download action, which is on every item, or that the copy button copies the image itself for non-text files. - Screen streaming omitted the Pop out button. - Shortcut pins: on a touch device every shortcut routes through the confirm dialog regardless of `confirm`, because the hover tooltip that would otherwise show the prompt is unreachable. - dispatch_delete_pin takes ids and group, not just a single id. Also diff-driven, from #955: the Settings → Agents → Launch guidance toggle had no docs coverage. Added a "Shorter startup rules" subsection to the Plugin section — what it drops, that it's an assertion rather than detection, that only Claude Code and Codex trim, that job runs don't, and that it applies at launch — plus an ambient tip pointing at it (since 0.34.2, confirmed by ancestry against the release commit). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly docs audit. Deep-dive area was the docs-pane Media & Sharing section (
next_focusfrom the last run), plus one diff-driven addition from #955.Verified clean
Enumerated as sets in both directions, no change needed: the four sidebar tabs vs
MediaSidebarTab, the eightdispatch_pintypes,dispatch_share's formats / 32KB content cap / simulator capture /updatesemantics, the fivedispatch_list_mediasources, the most-recent-50 media limit, MJPEG-over-CDP streaming with last-frame save, and the eight-pin group auto-collapse with per-agent persistence.Drift fixed (
docs-sections/media.tsx)reviewerType: "agent"fromdispatch_review_submit) — the more common case. The claimed three-value badge set was wrong too:reviews-sidebar-row.tsxmapspartially_resolvedto the Open label, so only Open and Resolved ever render. Rewritten around what the row actually shows, including the resolved count and the Approved · no feedback state.confirm, because the hover tooltip that would otherwise show the prompt is unreachable.dispatch_delete_pintakesidsandgroup, not just a singleid.Diff-driven addition (
docs-sections/plugin.tsx,tips.ts)#955 added Settings → Agents → Launch guidance → Use short startup rules with no docs coverage. Added a Shorter startup rules subsection: what it drops, that it's a user assertion rather than plugin detection, that only Claude Code and Codex agents trim (OpenCode/Cursor keep the full ruleset), that job runs are untouched, and that it applies at launch. Plus one ambient tip pointing at the new anchor —
since: 0.34.2, confirmed withgit merge-base --is-ancestor 31df8ecb 2d441f2c.Deferred to next run
docs/03-api-spec.mdstill has no rows for the agent pins HTTP routes (existing backlog item).dispatch_pinsmerge vs replace) are agent-facing only; not surfaced in the user docs.pnpm run format:write,pnpm run check, and the tips unit tests all pass.🤖 Generated with Claude Code