Uh oh!
There was an error while loading. Please reload this page.
Feat: Add Task skip notifications - #252
Draft
adbatista wants to merge 6 commits into
Draft
Conversation
adbatistaforce-pushed
the
adb/task-notification-skip-flags
branch
2 times, most recently
from
August 26, 2026 20:09
fc5c0e1 to
51c7878CompareMirror the skip_scheduled_run_notifications and skip_manual_run_notifications booleans introduced on scheduler tasks by semaphoreio/semaphore#1180 (projecthub REST API and v1alpha tasks endpoints). Task in the project spec gets both fields with explicit snake_case yaml tags — required because yaml.v2 defaults to full-lowercase names and NewProjectV1AlphaFromYaml uses UnmarshalStrict, so manifests carrying the new keys were a hard error. Without the fields, a sem edit project round-trip also dropped the flags from the PATCH body, resetting values set in the UI. TaskV1Alpha exposes them without omitempty, matching paused/suspended/ recurring, so sem get tasks always shows the value.
…round-trip Regression test: before the model fields existed, sem edit project omitted the flags from the PATCH body and the backend reset them to false.
adbatistaforce-pushed
the
adb/task-notification-skip-flags
branch
from
August 27, 2026 01:31
064fe29 to
1d06e5eCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.