Skip to content

fix: [DOCSPLAT-2058] Allow params serializer - for arrays - #1433

Open
lopenchi wants to merge 2 commits into
sendgrid:mainfrom
lopenchi:DOCSPLAT-2058
Open

fix: [DOCSPLAT-2058] Allow params serializer - for arrays#1433
lopenchi wants to merge 2 commits into
sendgrid:mainfrom
lopenchi:DOCSPLAT-2058

Conversation

@lopenchi

@lopenchilopenchi commented Mar 21, 2025

Copy link
Copy Markdown

Fixes

  • Allows seralization for query params. Info taken for this forum

Before fix:
/v3/marketing/integrations?ids[]=id1&ids[]=id2

After:
/v3/marketing/integrations?ids=id1&ids=id2

--

Doing this change because it was failing when testing SDK with prism, not sure if it failing when calling API.

For reference this is the code sample used:

constclient=require("@sendgrid/client");client.setApiKey(process.env.SENDGRID_API_KEY);constqueryParams={ids: ["id1","id2"]};constrequest={url: `/v3/marketing/integrations`,method: "DELETE",qs: queryParams,};client.request(request).then(([response,body])=>{console.log(response.statusCode);console.log(response.body);}).catch((error)=>{console.error(error);});

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@lopenchilopenchi changed the title [DOCSPLAT-1058] Allow params serializer - for arrays[DOCSPLAT-2058] Allow params serializer - for arraysMar 21, 2025
@lopenchilopenchi changed the title [DOCSPLAT-2058] Allow params serializer - for arraysfix: [DOCSPLAT-2058] Allow params serializer - for arraysMar 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lopenchi@manisha1997