Skip to content

(feat): add Hydreon RG-15 rainsensor - #802

Open
Thiemann96 wants to merge 33 commits into
masterfrom
add/rainsensor
Open

(feat): add Hydreon RG-15 rainsensor #802
Thiemann96 wants to merge 33 commits into
masterfrom
add/rainsensor

Conversation

@Thiemann96

@Thiemann96Thiemann96 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Added a template for the new rain sensor. In total the sensor produces 3 phenomena

  • Rain intensity
  • Rain accumulation (total; since the moment the sensor was first powered)
  • Rain accumulation (event; the amount of rain that has fallen during the most recent rain event)

@mpfeilmpfeil changed the title Add rainsensor Add Hydreon RG-15 rainsensor Sep 7, 2023
@mpfeilmpfeil added this to the v11.2.0 milestone Sep 7, 2023
mpfeil
mpfeil requested changes Sep 7, 2023
View reviewed changes

@mpfeilmpfeil left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefix everything that starts with rain_ with the sensor type rg15 to identify different rain sensors in the future.

Also change the file names in sensorDefinitions to rg15_rain_intensity and so on.

@mpfeilmpfeil changed the title Add Hydreon RG-15 rainsensor (feat): add Hydreon RG-15 rainsensor Sep 7, 2023
@mpfeilmpfeil removed this from the v11.2.0 milestone Oct 11, 2023
@mpfeilmpfeil added this to the v12.0.0 milestone Oct 20, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpfeilmpfeilmpfeil requested changes

Assignees

@Thiemann96Thiemann96

Labels

feature

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Thiemann96@mpfeil