Scaling for analog reads - #239
Merged
Merged
Conversation
tfry-gitforce-pushed
the
devel/analog_reads
branch
from
March 24, 2024 14:19
2abf3e0 to
9efe123CompareMemory usage change @ 9efe123
Click for full report table
Click for full report CSV |
tomcombriat
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! I let a few minor comments here and there that you can probably ignore. We should not forget to adapt the few examples.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Memory usage change @ 57f9451
Click for full report table
Click for full report CSV |
I ended up keeping most readings at 10 bits.
Uh oh!
There was an error while loading. Please reload this page.
tfry-gitforce-pushed
the
devel/analog_reads
branch
from
March 28, 2024 09:48
f623156 to
1b966b8Comparetfry-gitforce-pushed
the
devel/analog_reads
branch
from
March 28, 2024 10:15
1b966b8 to
34b199cCompareMemory usage change @ 34b199c
Click for full report table
Click for full report CSV |
tomcombriat
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, this adds scaling to analog reads.