Uh oh!
There was an error while loading. Please reload this page.
🐞 Keycloak: Doesn't show SSO providers in deferred login mode - #2661
Merged
Conversation
Agent-Logs-Url: https://github.com/sequentech/step/sessions/9d22d70b-20dc-47ef-8e64-34db4c1e0b12 Co-authored-by: edulix <81968+edulix@users.noreply.github.com>
Agent-Logs-Url: https://github.com/sequentech/step/sessions/9d22d70b-20dc-47ef-8e64-34db4c1e0b12 Co-authored-by: edulix <81968+edulix@users.noreply.github.com>
edulix
requested changes
May 11, 2026
edulix
left a comment
Contributor
There was a problem hiding this comment.
apply changes in this branch
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <aws.version>2.18.6</aws.version> | ||
| <keycloak.version>26.6.1</keycloak.version> | ||
| <junit.version>5.13.4</junit.version> |
ContributorAuthor
There was a problem hiding this comment.
Updated the added JUnit version to the latest stable release in 2295907.
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>3.5.4</version> |
ContributorAuthor
There was a problem hiding this comment.
Updated the Surefire plugin version to the latest release in 2295907.
CopilotAI
changed the title
[WIP] Fix login page SSO display issue for deferred user profileShow SSO providers in deferred login modeMay 11, 2026
Agent-Logs-Url: https://github.com/sequentech/step/sessions/c10eebf4-f73b-4235-b3bb-f04bd25b4714 Co-authored-by: edulix <81968+edulix@users.noreply.github.com>
ContributorAuthor
Applied the requested changes in this branch in 2295907. |
xalsina-sequent
marked this pull request as ready for review
May 12, 2026 09:18
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses missing SSO provider buttons when the admin-portal theme is used in “deferred login mode” by enabling and rendering the socialProviders section on register.ftl when formMode = 'LOGIN'. It also adds a regression test and updates Maven test dependencies/plugins so the theme module can run JUnit-based tests.
Changes:
- Enable
displaySocialProvidersforregister.ftlin login/deferred-login mode and add asocialProviderssection to render provider buttons. - Add a JUnit test that validates the template contains the expected social-provider rendering hooks.
- Add JUnit Jupiter dependencies and configure Maven Surefire for test execution.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/keycloak-extensions/sequent-theme/src/test/java/sequent/keycloak/theme/RegisterTemplateTest.java | Adds a template-content regression test for deferred login social provider rendering. |
| packages/keycloak-extensions/sequent-theme/src/main/resources/theme/sequent.admin-portal/login/register.ftl | Enables and implements social-provider rendering on the register template in login mode. |
| packages/keycloak-extensions/sequent-theme/pom.xml | Adds JUnit Jupiter dependencies and pins Surefire for running tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <#import "register-commons.ftl" as registerCommons> | ||
| <#include "intl-tel-input.ftl"> | ||
| <@layout.registrationLayout displayMessage=messagesPerField.exists('global') displayRequiredFields=true; section> | ||
| <@layout.registrationLayout displayMessage=messagesPerField.exists('global') displayRequiredFields=true displaySocialProviders=(formMode?? && formMode = 'LOGIN' && (social.providers)?has_content); section> |
Comment on lines
+225
to
+229
| <#list visibleProviders as p> | ||
| <ul class="${properties.kcFormSocialAccountListClass!} <#if visibleProviders?size gt 3>${properties.kcFormSocialAccountListGridClass!}</#if>"> | ||
| <li> | ||
| <a id="social-${p.alias}" class="${properties.kcFormSocialAccountListButtonClass!} <#if visibleProviders?size gt 3>${properties.kcFormSocialAccountGridItem!}</#if>" | ||
| type="button" href="${p.loginUrl}"> |
| assertTrue( | ||
| template.contains( | ||
| "displaySocialProviders=(formMode?? && formMode = 'LOGIN' && (social.providers)?has_content)")); |
| assertTrue(template.contains("id=\"kc-social-providers\"")); | ||
| assertTrue(template.contains("msg(\"identity-provider-login-label\")")); | ||
| assertTrue(template.contains("href=\"${p.loginUrl}\"")); | ||
| assertTrue(template.contains("${msg(p.displayName)!}")); |
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <aws.version>2.18.6</aws.version> | ||
| <keycloak.version>26.6.1</keycloak.version> | ||
| <junit.version>6.0.3</junit.version> |
Comment on lines
+232
to
+234
| <span class="${properties.kcFormSocialAccountNameClass!} kc-social-icon-text"><#if p.alias == 'digital-certificates'>${msg("digitalCertificateButton")}<#else>${msg(p.displayName)!}</#if></span> | ||
| <#else> | ||
| <span class="${properties.kcFormSocialAccountNameClass!}"><#if p.alias == 'digital-certificates'>${msg("digitalCertificateButton")}<#else>${msg(p.displayName)!}</#if></span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/12125