Uh oh!
There was an error while loading. Please reload this page.
✨ Voting Portal: Fix English translations (#2939) - #2946
Merged
Conversation
Parent issue: sequentech/meta#12743 Fixes six English voter-facing strings found during Ontario UAT (v10.0.0-rc.35). These are platform default translations, so the errors appear on every municipality. | Ref | Package | Key | Fix | | --- | --- | --- | --- | | Q1 | voting-portal | `ballotHelpDialog.content` | `elegible`->eligible, `section`->selection, `by activate`->by activating, `eligible to vote`->eligible to vote in | | Q2 | voting-portal | `titleHelpDialog.content` | third person -> second person; `coincides with`->matches | | Q6 | voting-portal | `electionSelectionScreen.description` | missing preposition `on` | | Q7 | voting-portal | `chooserHelpDialog.content` | comma splice; sentence never completes | | Q4 | ui-core | `validation.implicit.overVoteDisabled` | plural disagreement when max is 1 | | Q5 | ui-core | `validation.implicit.underVote` | system message -> plain language | ## Verification after deploy Ballot screen help (Q1), ballot list heading and help (Q6, Q7), Ballot Locator help (Q2), Mayor contest second selection attempt (Q4), review screen with a contest left blank (Q5). Confirm Q1 and Q7 on a second municipality - they are shared strings.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/12743
Fixes six English voter-facing strings found during Ontario UAT (v10.0.0-rc.35). These are platform default translations, so the errors appear on every municipality.
ballotHelpDialog.contentelegible->eligible,section->selection,by activate->by activating,eligible to vote->eligible to vote inelectionSelectionScreen.descriptiononchooserHelpDialog.contentvalidation.implicit.overVoteDisabledvalidation.implicit.underVoteVerification after deploy
Ballot screen help (Q1), ballot list heading and help (Q6, Q7), Ballot Locator help (Q2), Mayor contest second selection attempt (Q4), review screen with a contest left blank (Q5). Confirm Q1 and Q7 on a second municipality - they are shared strings.