Uh oh!
There was an error while loading. Please reload this page.
✨ Admin Portal: Voter editing quality of life features (#3078) - #3079
Merged
Conversation
Parent issue: sequentech/meta#12901 --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (25)
📝 WalkthroughWalkthroughThe change adds Keycloak user-profile validation parsing, structured Harvest errors, Admin Portal field validation, localized error handling, option-label support, hidden-attribute filtering, and documentation for the new attribute behavior. ChangesUser profile validation flow
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant AdminPortal
participant Harvest
participant SequentCore
participant Keycloak
AdminPortal->>Harvest: Create or edit user
Harvest->>Keycloak: Submit user profile
Keycloak-->>Harvest: Validation response
Harvest->>SequentCore: Parse profile validation errors
SequentCore-->>Harvest: Field errors and parameters
Harvest-->>AdminPortal: Structured validation response
AdminPortal->>AdminPortal: Localize fields and block invalid save
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Uh oh!
There was an error while loading. Please reload this page.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/12901
Summary by CodeRabbit
New Features
Bug Fixes
Documentation