Add go.mod and go.sum files to support Go modules. - #98
Conversation
creachadair
commented
Feb 4, 2019
Clearly the CI is in some way discontent with this change, I'm trying to work out why. |
creachadair
commented
Feb 4, 2019
Indeed, CI fails at HEAD: https://travis-ci.org/sergi/go-diff/jobs/488608466. So this PR didn't cause any new problems, but there are some existing ones that will need fixed. I'll look into that separately. |
creachadair
commented
Feb 4, 2019
Ok, I was able to fix the import path issue for |
creachadair
commented
Feb 4, 2019
I suggest dropping support for Go 1.8 entirely. Even though this repo only depends on golint as a verification tool, the dependency compatibility problem runs deeper. To address it you'll need to either install a newer version of Go to build golint, or find an older binary release to depend on (which golint does not itself provide). |
creachadair
commented
Feb 4, 2019
After that somewhat noisy debugging, I think this is ready for a review. |
creachadair
commented
Feb 12, 2019
I'm not sure who maintains the package, but if someone would be willing to take a look and let me know if this seems reasonable, I'd be grateful! I'm happy to address any concerns promptly. |
creachadair
commented
Feb 18, 2019
Ping! Is someone available to take a look and let me know whether you consider this a reasonable change? Thanks. |
creachadair
commented
Feb 26, 2019
Ping! @sergi do you have any thoughts about this proposed change? |
creachadair
commented
Mar 7, 2019
Ping! Is anyone maintaining this package, and willing to offer comment about this change? |
creachadair
commented
Mar 19, 2019
Ping! Can someone please take a look at this change? Even if you have concerns or objections, it would be helpful for us to know what they are. Thanks. |
creachadair
commented
Mar 27, 2019
Ping! Is someone available to take a look and let me know whether you consider this a reasonable change? Thanks. |
creachadair
commented
Apr 11, 2019
Ping! Can you please take a look when you have time? |
paper777
commented
Apr 16, 2019
@sergi PING |
creachadair
commented
Apr 29, 2019
Ping, @sergi. Please have a look when you can, thanks. |
creachadair
commented
May 14, 2019
@sergi Please take a look when you are able. |
creachadair
commented
May 24, 2019
Hi, @sergi, I'd be grateful for a review when you are able. Thanks! |
creachadair
commented
Jun 2, 2019
Greetings, @sergi! Please take a look when you have some time. |
creachadair
commented
Jun 17, 2019
Dear @sergi, can you please have a look at this PR when you have time? Thanks! |
edocevol
commented
Jul 3, 2019
@sergi Please review PR~~~ |
creachadair
commented
Jul 25, 2019
Hello, @sergi, when you have some available bandwidth, I'd be very grateful for a review here. If you have any questions or concerns about the change, I'll do my best to address them. Or if you disagree with the change entirely, it would be helpful to know why. Thanks! |
sergi
left a comment
There was a problem hiding this comment.
Sorry to be so late reviewing this. It should be good to go now. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
creachadair
commented
Aug 1, 2019
Thank you! |
creachadair
commented
Aug 2, 2019
Would you like me to squash the commits before merge? |
creachadair
commented
Aug 7, 2019
I went ahead and pre-squashed the commits so the merge will be clean once CI completes. |
creachadair
commented
Aug 20, 2019
Hi, @sergi, I think this is ready for a merge now (I don't have write access). Thanks! |
creachadair
commented
Sep 16, 2019
Hi, @sergi, I've updated the Travis CI config to include Go 1.13 now that it has been released, and added the new Go tool version tag to |
This commit contains no functional changes; it's just adding config files for the Go modules facility. Ideally this commit should also be accompanied by a new version tag, since the current latest tag is v1.0.0 from Nov. 2017, and several optimizations have been added since then. Related changes: - Update to the import canonical path for golint. - Add Go 1.10, 1.11, 1.12, and 1.13 to CI; drop 1.8.
This commit contains no functional changes; it's just adding config files for
the Go modules facility. Ideally this commit should also be accompanied by a
new version tag, since the current latest tag is v1.0.0 from Nov. 2017, and
several optimizations have been added since then.