Uh oh!
There was an error while loading. Please reload this page.
Add minimal config & content - #1
Merged
Merged
Conversation
baijum
commented
Sep 10, 2021
ContributorAuthor
The content is adopted from servicebinding/spec#175 |
baijumforce-pushed
the
minimal-config-content
branch
from
September 10, 2021 09:36
960f6ca to
846f3c6Comparearthurdm
commented
Sep 20, 2021
Member
thanks @baijum - could we replace the |
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
baijumforce-pushed
the
minimal-config-content
branch
from
September 20, 2021 15:27
a70d267 to
a4d6a27Comparebaijum
commented
Sep 20, 2021
ContributorAuthor
Done. |
scothis
reviewed
Sep 20, 2021
Comment on lines
+11
to
+27
| You can install the latest version of Service Binding Controller with this command: | ||
| ``` | ||
| kubectl apply -f https://github.com/k8s-service-bindings/service-binding-controller/releases/latest/download/release.yaml | ||
| ``` | ||
| If you need a particular version, replace `<version>` in this command: | ||
| ``` | ||
| kubectl apply -f https://github.com/k8s-service-bindings/service-binding-controller/releases/download/<version>/release.yaml | ||
| ``` | ||
| These are the major resources that is getting created during the installation: | ||
| 1. A namespace with name as `service-binding-controller-system`. All the namespace scoped resources are created in this namespace. | ||
| 2. Two CRDs: `ClusterWorkloadResourceMapping` (cluster scoped), `ServiceBinding` (namespace scoped) | ||
| 3. ClusterRole: `service-binding-controller-manager-role-with-aggregation-rule` |
Member
There was a problem hiding this comment.
let's remove this until these commands actually work
Comment on lines
+29
to
+35
| ## Creating Provisioned Services | ||
| Coming soon. | ||
| ## Binding Workloads with Services | ||
| Coming soon. |
Member
There was a problem hiding this comment.
remove. We can add these sections once we have content. Worth tracking in new issues.
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+72
to
+88
| For languages such as Go without operator overloading, separate functions can be used to retrieve bindings: | ||
| ``` | ||
| Bindings(_type string) []Binding | ||
| BindingsWithProvider(_type, provider string) []Binding | ||
| ``` | ||
| For languages such as Java with operator overloading, the same method name with different argument lists can be used to retrieve bindings: | ||
| ``` | ||
| public List<Binding> filterBindings(@Nullable String type) | ||
| public List<Binding> filterBindings(@Nullable String type, @Nullable String provider) | ||
| ``` | ||
| (Example taken from [Spring Cloud Bindings](https://github.com/spring-cloud/spring-cloud-bindings)) | ||
| The specification does not guarantee a single binding of a given type or type & provider tuple so the APIs return collections of bindings. Depending on your workload need, you can choose to connect to the first entry or all of them. |
Member
There was a problem hiding this comment.
can we link out to specific libraries instead? The function signatures here don't help me know what I actually need to do as a workload developer.
ContributorAuthor
There was a problem hiding this comment.
Now there are links to both Go and Java libraries.
Co-authored-by: Scott Andrews <scott@andrews.me> Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
baijumforce-pushed
the
minimal-config-content
branch
from
September 27, 2021 14:18
ddb9d40 to
2af466cComparenebhale
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Baiju Muthukadan baiju.m.mail@gmail.com