Skip to content

Remove mutability from parser/tokenizer APIs. - #548

Merged
jdm merged 8 commits into
mainfrom
no-mut-interface
Aug 7, 2024
Merged

Remove mutability from parser/tokenizer APIs.#548
jdm merged 8 commits into
mainfrom
no-mut-interface

Conversation

@jdm

@jdmjdm commented Aug 1, 2024

Copy link
Copy Markdown
Member

This is incompatible with a re-entrant parsing algorithm which is required by the web platform's document.write API.

@jdmjdm mentioned this pull request Aug 1, 2024
Merged
4 tasks
@jdm

jdm commented Aug 1, 2024

Copy link
Copy Markdown
MemberAuthor

FYI @Taym95

@Taym95

Taym95 commented Aug 1, 2024

Copy link
Copy Markdown
Member

FYI @Taym95

Thanks, Should I close the other PR? lets me knew is you need help here in clean up.

jdm
jdm commented Aug 1, 2024
View reviewed changes
Comment threadhtml5ever/examples/noop-tree-builder.rs Outdated
jdm
jdm commented Aug 1, 2024
View reviewed changes
Comment threadhtml5ever/examples/print-tree-actions.rs Outdated
jdm
jdm commented Aug 1, 2024
View reviewed changes
Comment threadhtml5ever/src/macros.rs Outdated
Some(x) => x,
{
let Some(x) = $opt else { $else_block };
x

@jdmjdmAug 1, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is necessary to minimize the scope of refcell borrows that are passed as arguments to the macro.

@jdm

jdm commented Aug 2, 2024

Copy link
Copy Markdown
MemberAuthor

FYI @Taym95

Thanks, Should I close the other PR? lets me knew is you need help here in clean up.

We can still merge the other PR, but we should remove all uses of &mut BufferQueue from the codebase in it (and uses like &mut input).

@jdmjdm mentioned this pull request Aug 3, 2024
Merged
@jdm
jdmforce-pushed the no-mut-interface branch from 795a40e to 1fe0441CompareAugust 7, 2024 03:41
@jdm
jdm marked this pull request as ready for review August 7, 2024 03:41
@jdm
jdmforce-pushed the no-mut-interface branch 2 times, most recently from 5858c9b to 6165801CompareAugust 7, 2024 03:48
@jdm
jdmforce-pushed the no-mut-interface branch from 6165801 to 07ed975CompareAugust 7, 2024 03:52
@jdm
jdmforce-pushed the no-mut-interface branch from 07ed975 to 1a93a35CompareAugust 7, 2024 03:53
@jdm

jdm commented Aug 7, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Ok, the code's cleaned up and commits are split into:

  1. mechanical changes - lots of removing &mut self from methods and adding Cell/RefCell
  2. new APIs needed by Support HTML parser reentrancy servo#32820
  3. functional changes - the TreeSink API for obtaining an element's name relies on borrowed data in ways that do not play nicely with naive usage of RefCell to store the element name data (ExpandedName docs)
  4. (and remaining commits) getting CI to pass

@jdm

jdm commented Aug 7, 2024

Copy link
Copy Markdown
MemberAuthor

@Taym95 Would you like to review this?

Taym95
Taym95 approved these changes Aug 7, 2024
View reviewed changes

@Taym95Taym95 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed all the changes, and everything looks good to me!

@jdm
jdm added this pull request to the merge queueAug 7, 2024
Merged via the queue into main with commit 801be63Aug 7, 2024
@jplattejplatte mentioned this pull request Aug 13, 2024
Closed
@mremre mentioned this pull request Aug 16, 2024
Merged
klensy added a commit to klensy/rust that referenced this pull request Mar 13, 2025
@klensy
bump html5ever to 0.28
b9e00b3
see servo/html5ever#548
@klensyklensy mentioned this pull request Mar 13, 2025
Merged
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 16, 2025
@jieyouxu
Rollup merge ofrust-lang#138465- klensy:linkchecker-b, r=Mark-Simul…
e42f339
…acrum
linkchecker: bump html5ever
Bumping html5ever to 0.28 required small refactoring, see servo/html5ever#548
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2025
@rust-timer
Unrolled build forrust-lang#138465
d1ab8a6
Rollup merge of rust-lang#138465 - klensy:linkchecker-b, r=Mark-Simulacrum
linkchecker: bump html5ever
Bumping html5ever to 0.28 required small refactoring, see servo/html5ever#548
@nicoburnsnicoburns mentioned this pull request Jul 14, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinsonmrobinsonmrobinson approved these changes
@Taym95Taym95Taym95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdm@Taym95@mrobinson