Uh oh!
There was an error while loading. Please reload this page.
Add cargo fmt to travis build config - #275
Merged
Merged
Conversation
Atul9force-pushed
the
add-cargo-fmt-to-travis-config
branch
from
June 21, 2020 12:33
1d09120 to
a6d79daCompareSimonSapin
commented
Jun 21, 2020
Member
Does this check all crates, or only the "root" one? I’m in favor of adding checking if it’s for all crates, and with the initial formatting in a separate commit from the CI change. |
SimonSapin
commented
Jun 21, 2020
Member
This seems relevant: |
Atul9force-pushed
the
add-cargo-fmt-to-travis-config
branch
from
June 21, 2020 13:00
a6d79da to
2aea98dCompareAtul9
commented
Jun 21, 2020
ContributorAuthor
@SimonSapin I have updated |
Atul9force-pushed
the
add-cargo-fmt-to-travis-config
branch
from
June 21, 2020 13:16
2aea98d to
a09f6dfCompareSimonSapin
commented
Jun 21, 2020
Member
Looks good, thanks! @bors-servo r+ |
bors-servo
commented
Jun 21, 2020
Contributor
📌 Commit a09f6df has been approved by |
bors-servo added a commit
that referenced
this pull request
Jun 21, 2020
Add cargo fmt to travis build config The stable build `cargo fmt` failure(https://travis-ci.com/github/servo/rust-cssparser/jobs/351864972) is fixed in #271, please merge that PR first.
bors-servo
commented
Jun 21, 2020
Contributor
bors-servo
commented
Jun 21, 2020
Contributor
💔 Test failed - checks-travis |
Atul9
commented
Jun 22, 2020
ContributorAuthor
@SimonSapin I have opened up a PR to fix the build failure #276, please check |
bors-servo added a commit
that referenced
this pull request
Jun 22, 2020
…mmy-type, r=SimonSapin Add rustfmt::skip to skip rustfmt for ProceduralMasqueradeDummyType enum This PR fixes this https://travis-ci.com/github/servo/rust-cssparser/jobs/351868518 build failure in #275 PR
SimonSapin
commented
Jun 22, 2020
Member
@bors-servo retry Queuing this after #276 |
bors-servo added a commit
that referenced
this pull request
Jun 22, 2020
Add cargo fmt to travis build config The stable build `cargo fmt` failure(https://travis-ci.com/github/servo/rust-cssparser/jobs/351864972) is fixed in #271, please merge that PR first.
bors-servo
commented
Jun 22, 2020
Contributor
bors-servo
commented
Jun 22, 2020
Contributor
💔 Test failed - checks-travis |
bors-servo added a commit
that referenced
this pull request
Jun 22, 2020
…mmy-type, r=SimonSapin Add rustfmt::skip to skip rustfmt for ProceduralMasqueradeDummyType enum This PR fixes this https://travis-ci.com/github/servo/rust-cssparser/jobs/351868518 build failure in #275 PR
SimonSapin
commented
Jun 22, 2020
Member
@bors-servo retry |
bors-servo
commented
Jun 22, 2020
Contributor
bors-servo
commented
Jun 22, 2020
Contributor
☀️ Test successful - checks-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stable build
cargo fmtfailure(https://travis-ci.com/github/servo/rust-cssparser/jobs/351864972) is fixed in #271, please merge that PR first.