Uh oh!
There was an error while loading. Please reload this page.
lib.rs: + 96-item inline support - #163
Merged
Merged
Conversation
emilio
reviewed
Sep 20, 2019
emilio
left a comment
Member
There was a problem hiding this comment.
Looks fair, though seems like for consistency we should also have 0x600 and 0x6000 too though, right?
bors-servo
commented
Oct 15, 2019
Contributor
☔ The latest upstream changes (presumably #167) made this pull request unmergeable. Please resolve the merge conflicts. |
emilioforce-pushed
the
master
branch
2 times, most recently
from
October 19, 2019 02:50
b3fbc21 to
0f197c5Compareemilio
commented
Oct 19, 2019
Member
I rebased and addressed my nit. @bors-servo r+ |
bors-servo
commented
Oct 19, 2019
Contributor
📌 Commit 0f197c5 has been approved by |
bors-servo
commented
Oct 19, 2019
Contributor
bors-servo pushed a commit
that referenced
this pull request
Oct 19, 2019
lib.rs: + 96-item inline support Added support for `[_; 96]` arrays I'm not sure how desirable this is to the broader user base, but I had a need for precisely this size for storing hex-encoded SHA384 hashes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/163) <!-- Reviewable:end -->
bors-servo
commented
Oct 19, 2019
Contributor
☀️ Test successful - checks-travis |
mbrubeck added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Oct 30, 2019
* [breaking change] Use `MaybeUninit` internally to avoid possible undefined behavior (servo#162, servo#170). * [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (servo#145). * [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (servo#164). * [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8, _]>` can implement the `std::io::Write` trait (servo#173). * Add support for 96-element small vectors, `SmallVec<[T; 96]>` (servo#163). * Iterators now implement `FusedIterator` (servo#172). * Indexing now uses the standard `SliceIndex` trait (servo#166). * Remove the deprecated `VecLike` trait (servo#165). * Use `NonNull` internally (servo#171). * Add automatic fuzz testing and MIRI testing (servo#168, servo#162). * Update syntax and formatting to Rust 2018 standard (servo#174, servo#167).
Merged
bors-servo pushed a commit
that referenced
this pull request
Nov 2, 2019
Version 1.0.0 * Requires Rust 1.36 or later. * [breaking change] Use `MaybeUninit` to avoid possible undefined behavior (#162, #170). * [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (#145). * [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (#164). * [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8;_]>` can implement the `std::io::Write` trait (#173). * Add support for 96-element small vectors, `SmallVec<[T; 96]>` (#163). * Iterators now implement `FusedIterator` (#172). * Indexing now uses the standard `SliceIndex` trait (#166). * Remove the deprecated `VecLike` trait (#165). * Use `NonNull` internally (#171). * Add automatic fuzz testing and MIRI testing (#168, #162). * Update syntax and formatting to Rust 2018 standard (#174, #167).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for
[_; 96]arraysI'm not sure how desirable this is to the broader user base, but I had a need for precisely this size for storing hex-encoded SHA384 hashes
This change is