Skip to content

Fix potential buffer overflow in insert_many - #254

Merged
bors-servo merged 1 commit into
servo:masterfrom
mbrubeck:overflow
Jan 8, 2021
Merged

Fix potential buffer overflow in insert_many#254
bors-servo merged 1 commit into
servo:masterfrom
mbrubeck:overflow

Conversation

@mbrubeck

@mbrubeckmbrubeck commented Jan 8, 2021

Copy link
Copy Markdown
Collaborator

Fixes#252.

@mbrubeckmbrubeck closed this Jan 8, 2021
@mbrubeckmbrubeck mentioned this pull request Jan 8, 2021
Closed
@mbrubeckmbrubeck reopened this Jan 8, 2021
@mbrubeckmbrubeck mentioned this pull request Jan 8, 2021
Closed
@mbrubeck

mbrubeck commented Jan 8, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Pushed a different version of the fix. This is a more invasive change, but it leaves the code a bit simpler and much easier to reason about.

The key observation is that the guard is no longer needed after we fill up the initial lower_size_bound slots of reserved space. While looping through any surplus items from the iterator, the SmallVec is in a valid state at the start and end of each iteration.

emilio
emilio approved these changes Jan 8, 2021
View reviewed changes

@emilioemilio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with that change unless I'm missing something.

Comment threadsrc/lib.rs Outdated
@mbrubeck

mbrubeck commented Jan 8, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@bors-servo r=emilio

@bors-servo

bors-servo commented Jan 8, 2021

Copy link
Copy Markdown
Contributor

📌 Commit 9998ba0 has been approved by emilio

@bors-servo

bors-servo commented Jan 8, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit 9998ba0 with merge 4e53e07...

@bors-servo

bors-servo commented Jan 8, 2021

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis
Approved by: emilio
Pushing 4e53e07 to master...

@bors-servo
bors-servo merged commit 4e53e07 into servo:masterJan 8, 2021
mbrubeck added a commit that referenced this pull request Jan 8, 2021
@mbrubeck
Fix potential buffer overflow in insert_many
5757ac5
Backport of #254 to the 0.6 branch. Fixes#253.
@drtychaidrtychai mentioned this pull request Jan 14, 2021
Closed
@EffortlessStevenEffortlessSteven mentioned this pull request May 18, 2026
Merged
EffortlessSteven added a commit to EffortlessMetrics/unsafe-review that referenced this pull request May 18, 2026
@EffortlessSteven
docs: record smallvec insert_many dogfood (#184)
4218e6c
Record servo/rust-smallvec#254 as an additional real PR-diff dogfood sample and keep support-tier claims experimental.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilioemilioemilio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Buffer overflow in insert_many()

3 participants

@mbrubeck@bors-servo@emilio