Uh oh!
There was an error while loading. Please reload this page.
Add benchmarks for push, insert, extend, and pushpop - #31
Merged
Conversation
| //! Small vectors in various sizes. These store a certain number of elements inline and fall back | ||
| //! to the heap for larger allocations. | ||
| #![feature(test)] |
Member
There was a problem hiding this comment.
This won't compile in stable, will it?
ContributorAuthor
There was a problem hiding this comment.
Correct. Let me work on factoring it into a conditionally compiled feature which is disabled by default.
ContributorAuthor
Looks like this on my machine (Mac book pro laptop) Travis CI looked like this. I don't think we can really rely on its numbers though. |
nipunn1313
commented
Sep 11, 2016
ContributorAuthor
Any update on this? |
jdm
commented
Sep 11, 2016
Member
@bors-servo: r+ |
bors-servo
commented
Sep 11, 2016
Contributor
📌 Commit 951f1d0 has been approved by |
bors-servo
commented
Sep 11, 2016
Contributor
⚡ Test exempted - status |
bors-servo pushed a commit
that referenced
this pull request
Sep 11, 2016
Add benchmarks for push, insert, extend, and pushpop Want to add these benchmarks so that we can more effectively detect regressions/improvements from PR's like #28 and #29. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/31) <!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Want to add these benchmarks so that we can more effectively detect regressions/improvements from PR's like #28 and #29.
This change is