Uh oh!
There was an error while loading. Please reload this page.
Add benchmarks for smallvec when it's on the stack - #97
Merged
Conversation
mbrubeck
commented
May 22, 2018
Collaborator
@bors-servo r+ |
bors-servo
commented
May 22, 2018
Contributor
📌 Commit 25255c8 has been approved by |
bors-servo
commented
May 22, 2018
Contributor
bors-servo pushed a commit
that referenced
this pull request
May 22, 2018
Add benchmarks for smallvec when it's on the stack This makes all the benchmarks generic so the addition of the `_small` variants didn't totally blow up the line count, which as an added bonus also means we don't get duplication between the vec and smallvec benchmarks. Results: ``` name vec.bench ns/iter smallvec.bench ns/iter diff ns/iter diff % speedup bench_extend 70 102 32 45.71% x 0.69 bench_extend_from_slice 65 52 -13 -20.00% x 1.25 bench_extend_from_slice_small 29 24 -5 -17.24% x 1.21 bench_extend_small 28 25 -3 -10.71% x 1.12 bench_from_slice 34 97 63 185.29% x 0.35 bench_from_slice_small 31 36 5 16.13% x 0.86 bench_insert 1,235 1,224 -11 -0.89% x 1.01 bench_insert_small 114 117 3 2.63% x 0.97 bench_macro_from_elem 45 55 10 22.22% x 0.82 bench_macro_from_elem_small 33 17 -16 -48.48% x 1.94 bench_macro_from_list 33 47 14 42.42% x 0.70 bench_push 379 462 83 21.90% x 0.82 bench_push_small 53 57 4 7.55% x 0.93 bench_pushpop 252 307 55 21.83% x 0.82 ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/97) <!-- Reviewable:end -->
bors-servo
commented
May 22, 2018
Contributor
☀️ Test successful - status-travis |
mbrubeck added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Jul 19, 2018
Changes in this release: * Fix possible double-free in `insert_many` when passed an iterator that panics in `next` (servo#103) * Add a new `union` feature (disabled by default) that reduces the size of the SmallVec struct (servo#94) * Improve performance of `extend` and `from_elem` (servo#93) * Improve performance of `drop` (servo#100) * Update dev-dependency on `bincode` (servo#102) * Update to build without `std` on current Rust nightly (servo#104) * Additional benchmarks (servo#95, servo#97).
mbrubeck added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Jul 19, 2018
Changes in this release: * Fix possible double-free in `insert_many` when passed an iterator that panics in `next` (servo#103) * Add a new `union` feature (disabled by default) that reduces the size of the SmallVec struct (servo#94) * Improve performance of `extend` and `from_elem` (servo#93) * Improve performance of `drop` (servo#100) * Update dev-dependency on `bincode` (servo#102) * Update to build without `std` on current Rust nightly (servo#104) * Additional benchmarks (servo#95, servo#97).
Merged
bors-servo pushed a commit
that referenced
this pull request
Jul 19, 2018
Version 0.6.3 Changes in this release: * Fix possible double-free in `insert_many` when passed an iterator that panics in `next` (#103) * Add a new `union` feature (disabled by default) that reduces the size of the SmallVec struct (#94) * Improve performance of `extend` and `from_elem` (#93) * Improve performance of `drop` (#100) * Update to build without `std` feature on current Rust nightly (#104) * Additional benchmarks (#95, #97) * Update dev-dependency on `bincode` (#102) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/105) <!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes all the benchmarks generic so the addition of the
_smallvariants didn't totally blow up the line count, which as an added bonus also means we don't get duplication between the vec and smallvec benchmarks.Results:
This change is