Uh oh!
There was an error while loading. Please reload this page.
Make macros accept idents where atom value is a valid ident - #296
Merged
Conversation
nicoburnsforce-pushed
the
ident-macro-arms
branch
from
September 5, 2025 03:15
676c191 to
5fbc5caCompareThis means that local_name!(html) will work as well
as local_name!("html")
Signed-off-by: Nico Burns <nico@nicoburns.com>nicoburnsforce-pushed
the
ident-macro-arms
branch
from
September 5, 2025 03:19
5fbc5ca to
d142c1bComparejdm
approved these changes
Sep 5, 2025
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburnsforce-pushed
the
ident-macro-arms
branch
from
September 5, 2025 11:59
fb2f4b6 to
72b4252CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that
local_name!(html)will work as well aslocal_name!("html").If the atom value is something like
foo-barthenlocal_name!("foo-bar")will work butlocal_name!(foo-bar)wont becausefoo-baris not a validident.