Skip to content

fix: use PGlite by default for db generation - #65

Open
iliasabk wants to merge 1 commit into
seveibar:mainfrom
iliasabk:fix/pglite-default-generate
Open

iliasabk wants to merge 1 commit into
seveibar:mainfrom
iliasabk:fix/pglite-default-generate

Conversation

@iliasabk

@iliasabk iliasabk commented Sep 10, 2026

Copy link
Copy Markdown

Summary

  • make the existing PGlite generation path the default, so db:generate does not require a running PostgreSQL server
  • keep external PostgreSQL generation available via --no-pglite
  • turn the PGlite generation test into a regression test that omits the flag
  • document the new default and escape hatch

Verification

  • bun test (3 pass, 0 fail)
  • bun run format:check
  • bun run build
  • git diff --check

@algora-pbc /claim #2

Closes #2

Copy link
Copy Markdown
Author

@algora-pbc /claim #2

Copy link
Copy Markdown
Author

Quick status note: all local verification passed (bun test, bun run format:check, bun run build, git diff --check). The three GitHub Actions runs currently show action_required with no jobs created, which appears to require maintainer approval before CI can execute for this first-time contribution. When convenient, could you approve the workflow runs and review the PR? Thanks!

@iliasabk
iliasabk force-pushed the fix/pglite-default-generate branch from 1c6e702 to fe429ad Compare September 11, 2026 10:06
@iliasabk

Copy link
Copy Markdown
Author

Friendly ping — the implementation is complete and all local checks pass (bun test, format:check, build). The Actions runs are still waiting on first-time-contributor approval; when you get a moment, could you approve the workflow so CI can verify? Happy to adjust anything once it runs.

@iliasabk

Copy link
Copy Markdown
Author

One more gentle ping while you're active — PR #65 is still open and mergeable with all local checks green (bun test, format:check, build). The three workflow runs only need the one-time first-time-contributor approval so CI can verify. Happy to adjust anything; otherwise this should be ready for review against #2. Thanks!

@iliasabk

Copy link
Copy Markdown
Author

Hi @seveibar — I see you're active today, so one quick note: PR #65 is ready and mergeable; the only outstanding step is the one-time Actions approval for first-time contributors (all local checks pass: bun test, format:check, build). No rush, just flagging while you're around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use pglite so that postgres isn't required when generating types

1 participant