Updating to amqp version 2.4.2

[bakkerd]

As amqplib is quite old (https://pypi.org/project/amqplib/#history) and I had some issues with reconnecting, I propose to update it to amqp, which has the same interface, but is maintained and widely used.

[nklapste]

Would it be possible to add some instrumentation testing for the GELFRabbitHandler to validate the implementation and usage of this library?

[bakkerd]

It would be an integration test, using an instance of rabbitmq. They are not in place, so it is not trivial to implement, which is why I did not include tests yet.
I see that you did add some for direct graylog integration testing, so I will try re-using those.

[nklapste]

Doing a integration test would be preferred. As it also give a implicit example on how to setup graypy -> rabbitmq -> graylog.

Good luck with working off of that past branch. I sadly was struggling with setting up a rabbitmq -> graylog environment with docker that was performant and effective for testing.

[martinvy]

Notice that the amqp.Connection class expects connect_timeout instead of connection_timeout keyword parameter. This is actually a bug also with current amqplib.

[bakkerd]

Fixed, good find.

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by 1.47%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #119 +/- ##
==========================================
+ Coverage 95.97% 97.44% +1.47% 
==========================================
Files 3 3 Lines 273 274 +1 ==========================================
+ Hits 262 267 +5 + Misses 11 7 -4

Impacted Files	Coverage Δ
graypy/rabbitmq.py	93.22% <100%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d1d85...4d92ac6. Read the comment docs.

[cyber-conor]

@martinvy any updates on this PR? This seems to fix an issue I've been having with graypy/amqp.

The amqplib module is so old that is requires you to stick to a version of setuptools no newer than 59.8.0 in order to install graypy with the amqp extra. Otherwise after doing an install of graypy will get you this issue:

>>>importgraypy>>>graypy.GELFRabbitHandler()
Traceback (mostrecentcalllast):
File"<stdin>", line1, in<module>AttributeError: module'graypy'hasnoattribute'GELFRabbitHandler'

It would be fantastic if we could get a new graypy release in pypi with this fix.

[bakkerd]

@cyber-conor Good question, I think this pull request is good to go. At the time nobody seemed to work on this project anymore, but I see some recent updates in the last months. @nklapste, could you have a look at this, and if you have the “authority” merge this if you are content?

EDIT: @nklapste I even added the integration test you requested😉

[billsioros]

Would love to see this merged! 💯 I've been using @bakkerd 's fork and I have not come across any issues!

[martinvy]

Hi guys, I am sorry for the late reply, I missed the notification.

I suggest to use newer amqp version. We currently use my fork in production for few years already, having "amqp>=2.5.1,<6.0.0" in setup.py. We intentionally do not hard-pin the exact version for better flexibility, but amqp==5.3.1 is installed on our systems at the moment to be exact.

My fork contains only one more change (comparing to the main repo) and that's allowing to set timeouts on GELFRabbitHandler, see this commit, which would be great to have also in the main repo.

The PR looks good otherwise. It is nice that you created also the test 👍

[bakkerd]

As amqplib is quite old (https://pypi.org/project/amqplib/#history) and I had some issues with reconnecting, I propose to update it to amqp, which has the same interface, but is maintained and widely used.

[nklapste]

Would it be possible to add some instrumentation testing for the GELFRabbitHandler to validate the implementation and usage of this library?

[bakkerd]

It would be an integration test, using an instance of rabbitmq. They are not in place, so it is not trivial to implement, which is why I did not include tests yet.
I see that you did add some for direct graylog integration testing, so I will try re-using those.

[nklapste]

Doing a integration test would be preferred. As it also give a implicit example on how to setup graypy -> rabbitmq -> graylog.

Good luck with working off of that past branch. I sadly was struggling with setting up a rabbitmq -> graylog environment with docker that was performant and effective for testing.

[martinvy]

Notice that the amqp.Connection class expects connect_timeout instead of connection_timeout keyword parameter. This is actually a bug also with current amqplib.

[bakkerd]

Fixed, good find.

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by 1.47%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #119 +/- ##
==========================================
+ Coverage 95.97% 97.44% +1.47% 
==========================================
Files 3 3 Lines 273 274 +1 ==========================================
+ Hits 262 267 +5 + Misses 11 7 -4

Impacted Files	Coverage Δ
graypy/rabbitmq.py	93.22% <100%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d1d85...4d92ac6. Read the comment docs.

[cyber-conor]

@martinvy any updates on this PR? This seems to fix an issue I've been having with graypy/amqp.

The amqplib module is so old that is requires you to stick to a version of setuptools no newer than 59.8.0 in order to install graypy with the amqp extra. Otherwise after doing an install of graypy will get you this issue:

>>>importgraypy>>>graypy.GELFRabbitHandler()
Traceback (mostrecentcalllast):
File"<stdin>", line1, in<module>AttributeError: module'graypy'hasnoattribute'GELFRabbitHandler'

It would be fantastic if we could get a new graypy release in pypi with this fix.

[bakkerd]

@cyber-conor Good question, I think this pull request is good to go. At the time nobody seemed to work on this project anymore, but I see some recent updates in the last months. @nklapste, could you have a look at this, and if you have the “authority” merge this if you are content?

EDIT: @nklapste I even added the integration test you requested😉

[billsioros]

Would love to see this merged! 💯 I've been using @bakkerd 's fork and I have not come across any issues!

[martinvy]

Hi guys, I am sorry for the late reply, I missed the notification.

I suggest to use newer amqp version. We currently use my fork in production for few years already, having "amqp>=2.5.1,<6.0.0" in setup.py. We intentionally do not hard-pin the exact version for better flexibility, but amqp==5.3.1 is installed on our systems at the moment to be exact.

My fork contains only one more change (comparing to the main repo) and that's allowing to set timeouts on GELFRabbitHandler, see this commit, which would be great to have also in the main repo.

The PR looks good otherwise. It is nice that you created also the test 👍

[bakkerd]

As amqplib is quite old (https://pypi.org/project/amqplib/#history) and I had some issues with reconnecting, I propose to update it to amqp, which has the same interface, but is maintained and widely used.

[nklapste]

Would it be possible to add some instrumentation testing for the GELFRabbitHandler to validate the implementation and usage of this library?

[bakkerd]

It would be an integration test, using an instance of rabbitmq. They are not in place, so it is not trivial to implement, which is why I did not include tests yet.
I see that you did add some for direct graylog integration testing, so I will try re-using those.

[nklapste]

Doing a integration test would be preferred. As it also give a implicit example on how to setup graypy -> rabbitmq -> graylog.

Good luck with working off of that past branch. I sadly was struggling with setting up a rabbitmq -> graylog environment with docker that was performant and effective for testing.

[martinvy]

Notice that the amqp.Connection class expects connect_timeout instead of connection_timeout keyword parameter. This is actually a bug also with current amqplib.

[bakkerd]

Fixed, good find.

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by 1.47%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #119 +/- ##
==========================================
+ Coverage 95.97% 97.44% +1.47% 
==========================================
Files 3 3 Lines 273 274 +1 ==========================================
+ Hits 262 267 +5 + Misses 11 7 -4

Impacted Files	Coverage Δ
graypy/rabbitmq.py	93.22% <100%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d1d85...4d92ac6. Read the comment docs.

[cyber-conor]

@martinvy any updates on this PR? This seems to fix an issue I've been having with graypy/amqp.

The amqplib module is so old that is requires you to stick to a version of setuptools no newer than 59.8.0 in order to install graypy with the amqp extra. Otherwise after doing an install of graypy will get you this issue:

>>>importgraypy>>>graypy.GELFRabbitHandler()
Traceback (mostrecentcalllast):
File"<stdin>", line1, in<module>AttributeError: module'graypy'hasnoattribute'GELFRabbitHandler'

It would be fantastic if we could get a new graypy release in pypi with this fix.

[bakkerd]

@cyber-conor Good question, I think this pull request is good to go. At the time nobody seemed to work on this project anymore, but I see some recent updates in the last months. @nklapste, could you have a look at this, and if you have the “authority” merge this if you are content?

EDIT: @nklapste I even added the integration test you requested😉

[billsioros]

Would love to see this merged! 💯 I've been using @bakkerd 's fork and I have not come across any issues!

[martinvy]

Hi guys, I am sorry for the late reply, I missed the notification.

I suggest to use newer amqp version. We currently use my fork in production for few years already, having "amqp>=2.5.1,<6.0.0" in setup.py. We intentionally do not hard-pin the exact version for better flexibility, but amqp==5.3.1 is installed on our systems at the moment to be exact.

My fork contains only one more change (comparing to the main repo) and that's allowing to set timeouts on GELFRabbitHandler, see this commit, which would be great to have also in the main repo.

The PR looks good otherwise. It is nice that you created also the test 👍

[bakkerd]

As amqplib is quite old (https://pypi.org/project/amqplib/#history) and I had some issues with reconnecting, I propose to update it to amqp, which has the same interface, but is maintained and widely used.

[nklapste]

Would it be possible to add some instrumentation testing for the GELFRabbitHandler to validate the implementation and usage of this library?

[bakkerd]

It would be an integration test, using an instance of rabbitmq. They are not in place, so it is not trivial to implement, which is why I did not include tests yet.
I see that you did add some for direct graylog integration testing, so I will try re-using those.

[nklapste]

Doing a integration test would be preferred. As it also give a implicit example on how to setup graypy -> rabbitmq -> graylog.

Good luck with working off of that past branch. I sadly was struggling with setting up a rabbitmq -> graylog environment with docker that was performant and effective for testing.

[martinvy]

Notice that the amqp.Connection class expects connect_timeout instead of connection_timeout keyword parameter. This is actually a bug also with current amqplib.

[bakkerd]

Fixed, good find.

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by 1.47%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #119 +/- ##
==========================================
+ Coverage 95.97% 97.44% +1.47% 
==========================================
Files 3 3 Lines 273 274 +1 ==========================================
+ Hits 262 267 +5 + Misses 11 7 -4

Impacted Files	Coverage Δ
graypy/rabbitmq.py	93.22% <100%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d1d85...4d92ac6. Read the comment docs.

[cyber-conor]

@martinvy any updates on this PR? This seems to fix an issue I've been having with graypy/amqp.

The amqplib module is so old that is requires you to stick to a version of setuptools no newer than 59.8.0 in order to install graypy with the amqp extra. Otherwise after doing an install of graypy will get you this issue:

>>>importgraypy>>>graypy.GELFRabbitHandler()
Traceback (mostrecentcalllast):
File"<stdin>", line1, in<module>AttributeError: module'graypy'hasnoattribute'GELFRabbitHandler'

It would be fantastic if we could get a new graypy release in pypi with this fix.

[bakkerd]

@cyber-conor Good question, I think this pull request is good to go. At the time nobody seemed to work on this project anymore, but I see some recent updates in the last months. @nklapste, could you have a look at this, and if you have the “authority” merge this if you are content?

EDIT: @nklapste I even added the integration test you requested😉

[billsioros]

Would love to see this merged! 💯 I've been using @bakkerd 's fork and I have not come across any issues!

[martinvy]

Hi guys, I am sorry for the late reply, I missed the notification.

I suggest to use newer amqp version. We currently use my fork in production for few years already, having "amqp>=2.5.1,<6.0.0" in setup.py. We intentionally do not hard-pin the exact version for better flexibility, but amqp==5.3.1 is installed on our systems at the moment to be exact.

My fork contains only one more change (comparing to the main repo) and that's allowing to set timeouts on GELFRabbitHandler, see this commit, which would be great to have also in the main repo.

The PR looks good otherwise. It is nice that you created also the test 👍

[bakkerd]

As amqplib is quite old (https://pypi.org/project/amqplib/#history) and I had some issues with reconnecting, I propose to update it to amqp, which has the same interface, but is maintained and widely used.

[nklapste]

Would it be possible to add some instrumentation testing for the GELFRabbitHandler to validate the implementation and usage of this library?

[bakkerd]

It would be an integration test, using an instance of rabbitmq. They are not in place, so it is not trivial to implement, which is why I did not include tests yet.
I see that you did add some for direct graylog integration testing, so I will try re-using those.

[nklapste]

Doing a integration test would be preferred. As it also give a implicit example on how to setup graypy -> rabbitmq -> graylog.

Good luck with working off of that past branch. I sadly was struggling with setting up a rabbitmq -> graylog environment with docker that was performant and effective for testing.

[martinvy]

Notice that the amqp.Connection class expects connect_timeout instead of connection_timeout keyword parameter. This is actually a bug also with current amqplib.

[bakkerd]

Fixed, good find.

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by 1.47%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #119 +/- ##
==========================================
+ Coverage 95.97% 97.44% +1.47% 
==========================================
Files 3 3 Lines 273 274 +1 ==========================================
+ Hits 262 267 +5 + Misses 11 7 -4

Impacted Files	Coverage Δ
graypy/rabbitmq.py	93.22% <100%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d1d85...4d92ac6. Read the comment docs.

[cyber-conor]

@martinvy any updates on this PR? This seems to fix an issue I've been having with graypy/amqp.

The amqplib module is so old that is requires you to stick to a version of setuptools no newer than 59.8.0 in order to install graypy with the amqp extra. Otherwise after doing an install of graypy will get you this issue:

>>>importgraypy>>>graypy.GELFRabbitHandler()
Traceback (mostrecentcalllast):
File"<stdin>", line1, in<module>AttributeError: module'graypy'hasnoattribute'GELFRabbitHandler'

It would be fantastic if we could get a new graypy release in pypi with this fix.

[bakkerd]

@cyber-conor Good question, I think this pull request is good to go. At the time nobody seemed to work on this project anymore, but I see some recent updates in the last months. @nklapste, could you have a look at this, and if you have the “authority” merge this if you are content?

EDIT: @nklapste I even added the integration test you requested😉

[billsioros]

Would love to see this merged! 💯 I've been using @bakkerd 's fork and I have not come across any issues!

[martinvy]

Hi guys, I am sorry for the late reply, I missed the notification.

I suggest to use newer amqp version. We currently use my fork in production for few years already, having "amqp>=2.5.1,<6.0.0" in setup.py. We intentionally do not hard-pin the exact version for better flexibility, but amqp==5.3.1 is installed on our systems at the moment to be exact.

My fork contains only one more change (comparing to the main repo) and that's allowing to set timeouts on GELFRabbitHandler, see this commit, which would be great to have also in the main repo.

The PR looks good otherwise. It is nice that you created also the test 👍

[bakkerd]

As amqplib is quite old (https://pypi.org/project/amqplib/#history) and I had some issues with reconnecting, I propose to update it to amqp, which has the same interface, but is maintained and widely used.

[nklapste]

Would it be possible to add some instrumentation testing for the GELFRabbitHandler to validate the implementation and usage of this library?

[bakkerd]

It would be an integration test, using an instance of rabbitmq. They are not in place, so it is not trivial to implement, which is why I did not include tests yet.
I see that you did add some for direct graylog integration testing, so I will try re-using those.

[nklapste]

Doing a integration test would be preferred. As it also give a implicit example on how to setup graypy -> rabbitmq -> graylog.

Good luck with working off of that past branch. I sadly was struggling with setting up a rabbitmq -> graylog environment with docker that was performant and effective for testing.

[martinvy]

Notice that the amqp.Connection class expects connect_timeout instead of connection_timeout keyword parameter. This is actually a bug also with current amqplib.

[bakkerd]

Fixed, good find.

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by 1.47%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #119 +/- ##
==========================================
+ Coverage 95.97% 97.44% +1.47% 
==========================================
Files 3 3 Lines 273 274 +1 ==========================================
+ Hits 262 267 +5 + Misses 11 7 -4

Impacted Files	Coverage Δ
graypy/rabbitmq.py	93.22% <100%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d1d85...4d92ac6. Read the comment docs.

[cyber-conor]

@martinvy any updates on this PR? This seems to fix an issue I've been having with graypy/amqp.

The amqplib module is so old that is requires you to stick to a version of setuptools no newer than 59.8.0 in order to install graypy with the amqp extra. Otherwise after doing an install of graypy will get you this issue:

>>>importgraypy>>>graypy.GELFRabbitHandler()
Traceback (mostrecentcalllast):
File"<stdin>", line1, in<module>AttributeError: module'graypy'hasnoattribute'GELFRabbitHandler'

It would be fantastic if we could get a new graypy release in pypi with this fix.

[bakkerd]

@cyber-conor Good question, I think this pull request is good to go. At the time nobody seemed to work on this project anymore, but I see some recent updates in the last months. @nklapste, could you have a look at this, and if you have the “authority” merge this if you are content?

EDIT: @nklapste I even added the integration test you requested😉

[billsioros]

Would love to see this merged! 💯 I've been using @bakkerd 's fork and I have not come across any issues!

[martinvy]

Hi guys, I am sorry for the late reply, I missed the notification.

I suggest to use newer amqp version. We currently use my fork in production for few years already, having "amqp>=2.5.1,<6.0.0" in setup.py. We intentionally do not hard-pin the exact version for better flexibility, but amqp==5.3.1 is installed on our systems at the moment to be exact.

My fork contains only one more change (comparing to the main repo) and that's allowing to set timeouts on GELFRabbitHandler, see this commit, which would be great to have also in the main repo.

The PR looks good otherwise. It is nice that you created also the test 👍

[bakkerd]

As amqplib is quite old (https://pypi.org/project/amqplib/#history) and I had some issues with reconnecting, I propose to update it to amqp, which has the same interface, but is maintained and widely used.

[nklapste]

Would it be possible to add some instrumentation testing for the GELFRabbitHandler to validate the implementation and usage of this library?

[bakkerd]

It would be an integration test, using an instance of rabbitmq. They are not in place, so it is not trivial to implement, which is why I did not include tests yet.
I see that you did add some for direct graylog integration testing, so I will try re-using those.

[nklapste]

Doing a integration test would be preferred. As it also give a implicit example on how to setup graypy -> rabbitmq -> graylog.

Good luck with working off of that past branch. I sadly was struggling with setting up a rabbitmq -> graylog environment with docker that was performant and effective for testing.

[martinvy]

Notice that the amqp.Connection class expects connect_timeout instead of connection_timeout keyword parameter. This is actually a bug also with current amqplib.

[bakkerd]

Fixed, good find.

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by 1.47%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #119 +/- ##
==========================================
+ Coverage 95.97% 97.44% +1.47% 
==========================================
Files 3 3 Lines 273 274 +1 ==========================================
+ Hits 262 267 +5 + Misses 11 7 -4

Impacted Files	Coverage Δ
graypy/rabbitmq.py	93.22% <100%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d1d85...4d92ac6. Read the comment docs.

[cyber-conor]

@martinvy any updates on this PR? This seems to fix an issue I've been having with graypy/amqp.

The amqplib module is so old that is requires you to stick to a version of setuptools no newer than 59.8.0 in order to install graypy with the amqp extra. Otherwise after doing an install of graypy will get you this issue:

>>>importgraypy>>>graypy.GELFRabbitHandler()
Traceback (mostrecentcalllast):
File"<stdin>", line1, in<module>AttributeError: module'graypy'hasnoattribute'GELFRabbitHandler'

It would be fantastic if we could get a new graypy release in pypi with this fix.

[bakkerd]

@cyber-conor Good question, I think this pull request is good to go. At the time nobody seemed to work on this project anymore, but I see some recent updates in the last months. @nklapste, could you have a look at this, and if you have the “authority” merge this if you are content?

EDIT: @nklapste I even added the integration test you requested😉

[billsioros]

Would love to see this merged! 💯 I've been using @bakkerd 's fork and I have not come across any issues!

[martinvy]

Hi guys, I am sorry for the late reply, I missed the notification.

I suggest to use newer amqp version. We currently use my fork in production for few years already, having "amqp>=2.5.1,<6.0.0" in setup.py. We intentionally do not hard-pin the exact version for better flexibility, but amqp==5.3.1 is installed on our systems at the moment to be exact.

My fork contains only one more change (comparing to the main repo) and that's allowing to set timeouts on GELFRabbitHandler, see this commit, which would be great to have also in the main repo.

The PR looks good otherwise. It is nice that you created also the test 👍

[bakkerd]

As amqplib is quite old (https://pypi.org/project/amqplib/#history) and I had some issues with reconnecting, I propose to update it to amqp, which has the same interface, but is maintained and widely used.

[nklapste]

Would it be possible to add some instrumentation testing for the GELFRabbitHandler to validate the implementation and usage of this library?

[bakkerd]

It would be an integration test, using an instance of rabbitmq. They are not in place, so it is not trivial to implement, which is why I did not include tests yet.
I see that you did add some for direct graylog integration testing, so I will try re-using those.

[nklapste]

Doing a integration test would be preferred. As it also give a implicit example on how to setup graypy -> rabbitmq -> graylog.

Good luck with working off of that past branch. I sadly was struggling with setting up a rabbitmq -> graylog environment with docker that was performant and effective for testing.

[martinvy]

Notice that the amqp.Connection class expects connect_timeout instead of connection_timeout keyword parameter. This is actually a bug also with current amqplib.

[bakkerd]

Fixed, good find.

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by 1.47%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #119 +/- ##
==========================================
+ Coverage 95.97% 97.44% +1.47% 
==========================================
Files 3 3 Lines 273 274 +1 ==========================================
+ Hits 262 267 +5 + Misses 11 7 -4

Impacted Files	Coverage Δ
graypy/rabbitmq.py	93.22% <100%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d1d85...4d92ac6. Read the comment docs.

[cyber-conor]

@martinvy any updates on this PR? This seems to fix an issue I've been having with graypy/amqp.

The amqplib module is so old that is requires you to stick to a version of setuptools no newer than 59.8.0 in order to install graypy with the amqp extra. Otherwise after doing an install of graypy will get you this issue:

>>>importgraypy>>>graypy.GELFRabbitHandler()
Traceback (mostrecentcalllast):
File"<stdin>", line1, in<module>AttributeError: module'graypy'hasnoattribute'GELFRabbitHandler'

It would be fantastic if we could get a new graypy release in pypi with this fix.

[bakkerd]

@cyber-conor Good question, I think this pull request is good to go. At the time nobody seemed to work on this project anymore, but I see some recent updates in the last months. @nklapste, could you have a look at this, and if you have the “authority” merge this if you are content?

EDIT: @nklapste I even added the integration test you requested😉

[billsioros]

Would love to see this merged! 💯 I've been using @bakkerd 's fork and I have not come across any issues!

[martinvy]

Hi guys, I am sorry for the late reply, I missed the notification.

I suggest to use newer amqp version. We currently use my fork in production for few years already, having "amqp>=2.5.1,<6.0.0" in setup.py. We intentionally do not hard-pin the exact version for better flexibility, but amqp==5.3.1 is installed on our systems at the moment to be exact.

My fork contains only one more change (comparing to the main repo) and that's allowing to set timeouts on GELFRabbitHandler, see this commit, which would be great to have also in the main repo.

The PR looks good otherwise. It is nice that you created also the test 👍