Skip to content

Xarray upstream fix - #485

Merged
mergify[bot] merged 1 commit into
sgkit-dev:masterfrom
tomwhite:xarray-upstream-fix
Mar 8, 2021
Merged

Xarray upstream fix#485
mergify[bot] merged 1 commit into
sgkit-dev:masterfrom
tomwhite:xarray-upstream-fix

Conversation

@tomwhite

Copy link
Copy Markdown
Member

Fixes#477

@jeromekelleherjeromekelleher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but idid you mean to hit requirements?

Comment threadrequirements.txt Outdated
xarray
dask[array] == 2021.02.0
distributed == 2021.02.0
dask[array]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this undoes earlier PR?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it would go in after #482, but actually it is independent. I've rebased to remove #482 from this PR.

@tomwhite
tomwhiteforce-pushed the xarray-upstream-fix branch from 9074c04 to 1a02ccbCompareMarch 8, 2021 16:57
@codecov-io

codecov-io commented Mar 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #485 (1a02ccb) into master (12223d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #485 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 34 34 Lines 2389 2389 =========================================
Hits 2389 2389 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12223d2...1a02ccb. Read the comment docs.

@tomwhitetomwhite added the auto-merge Auto merge label for mergify test flight label Mar 8, 2021
@mergify
mergifyBot merged commit 52b0716 into sgkit-dev:masterMar 8, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-mergeAuto merge label for mergify test flight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream build failing for 2 weeks

3 participants

@tomwhite@codecov-io@jeromekelleher