Skip to content

Get Diagnostics Data API - #27

Closed
dhlaluku wants to merge 1 commit into
mainfrom
retrieve-diagnostics-data
Closed

Get Diagnostics Data API#27
dhlaluku wants to merge 1 commit into
mainfrom
retrieve-diagnostics-data

Conversation

@dhlaluku

@dhlalukudhlaluku commented Nov 29, 2018•
edited
Loading

Copy link
Copy Markdown

Get Diagnostics Data from system VMs
Docs; https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Get+Diagnostics+Data+API

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@dhlaluku
dhlalukuforce-pushed the retrieve-diagnostics-data branch from c06d256 to fa5379aCompareDecember 4, 2018 17:41
@dhlaluku
dhlaluku changed the base branch from master to 4.11December 4, 2018 17:42
@dhlaluku
dhlaluku changed the base branch from 4.11 to masterDecember 4, 2018 17:43
@dhlaluku
dhlaluku changed the base branch from master to 4.11December 4, 2018 17:44
@dhlaluku
dhlaluku changed the base branch from 4.11 to masterDecember 4, 2018 17:44
@dhlalukudhlaluku self-assigned this Dec 4, 2018
@dhlalukudhlaluku added this to the 4.12.0 milestone Dec 4, 2018
@dhlaluku
dhlalukuforce-pushed the retrieve-diagnostics-data branch from 423d1c6 to 18b55a0CompareDecember 5, 2018 06:12
nvazquez
nvazquez reviewed Dec 6, 2018
View reviewed changes
Comment threadserver/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsDataTO.java Outdated
@borisstoyanov

borisstoyanov commented Jan 15, 2019

Copy link
Copy Markdown
Member

@dhlaluku this has been passed to me for testing but the title still says "work in progress"?

@dhlaluku

dhlaluku commented Jan 15, 2019

Copy link
Copy Markdown
Author

@borisstoyanov let me fix the merge conflict and remove the WIP from the label

@dhlaluku
dhlalukuforce-pushed the retrieve-diagnostics-data branch from bbbe373 to fda69b2CompareJanuary 15, 2019 07:23
@dhlalukudhlaluku changed the title [WIP] Get Diagnostics Data API (for review)Get Diagnostics Data APIJan 15, 2019
@dhlaluku
dhlaluku changed the base branch from master to 4.11January 15, 2019 07:26
@dhlaluku
dhlaluku changed the base branch from 4.11 to masterJanuary 15, 2019 07:27
@dhlaluku
dhlalukuforce-pushed the retrieve-diagnostics-data branch from fda69b2 to ff46636CompareFebruary 25, 2019 08:07
DaanHoogland
DaanHoogland reviewed Mar 1, 2019
View reviewed changes

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions and comments

Comment thread...src/main/java/org/apache/cloudstack/api/command/admin/diagnostics/GetDiagnosticsDataCmd.java Outdated
Comment thread...src/main/java/org/apache/cloudstack/api/command/admin/diagnostics/GetDiagnosticsDataCmd.java
Comment thread...src/main/java/org/apache/cloudstack/api/response/diagnostics/GetDiagnosticsDataResponse.java
Comment threadcore/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
_eachTimeout = Duration.standardSeconds(cmd.getTimeout());
final ExecutionResult result = _vrDeployer.executeInVR(cmd.getRouterAccessIp(), VRScripts.RETRIEVE_DIAGNOSTICS, fileList, _eachTimeout);
if (result.isSuccess()){
return new PrepareFilesAnswer(cmd, true, result.getDetails());

@DaanHooglandDaanHooglandMar 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no validation of result.details?

@dhlalukudhlalukuMar 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No validation required here, success/fail is handled in the service layer class "DiagnosticsServiceImpl"

@dhlalukudhlalukuMar 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for validation here, script/command execution should be propagated back to service layer using command-answer pattern

Comment threadcore/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
Comment thread...sors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java Outdated
Comment thread...sors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java Outdated
* @param fileName filepath inside system vm, /root/diagnostics_files_xxxx.tar
*/
protected void cleanUpFileInVm(String vmIP, String fileName) {
final String PERM_KEY = "/root/.ssh/id_rsa.cloud";

@DaanHooglandDaanHooglandMar 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this here

@dhlalukudhlalukuMar 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, extracted Zip file in system vm file cleanup to Network element command which makes it hypervisor agnostic

Comment threadserver/src/main/java/com/cloud/server/StatsCollector.java
return false;
}

public boolean imageStoreHasEnoughCapacity(DataStore imageStore, Double storeCapThreshold) {

@DaanHooglandDaanHooglandMar 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc to explain how storeCapThreshold is used would be nice

Comment threadserver/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java Outdated
Comment threadserver/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java Outdated
dhlaluku pushed a commit that referenced this pull request Mar 12, 2019
Paul Angus
Merge pull request#27from shapeblue/dingane/fro210
1175081
BT-HF66 Publish disk resize event in cloud_usage
@dhlaluku
dhlalukuforce-pushed the retrieve-diagnostics-data branch from 679e170 to fbbee31CompareMarch 19, 2019 15:28
Dingane Hlaluku
* Complete API implementation
0b247be
* Complete UI integration
* Complete marvin test
* Complete Secondary storage GC background task
@dhlaluku
dhlalukuforce-pushed the retrieve-diagnostics-data branch from fbbee31 to 0b247beCompareMarch 21, 2019 10:34
shwstppr added a commit that referenced this pull request Nov 3, 2020
@shwstppr
Volume migration fix wrt#22(#27)
03d9cb5
* fix worker vm
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* remove unwanted logs
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
M. Weber@yadvr
dashboard improvements (#27)
f71ed85
* Add new grid values new classes to replace inline stlyes with it
* Fix navigation scroll behavior
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvryadvr closed this in c9a75e2Jan 20, 2021
@yadvryadvr reopened this Jan 20, 2021
shwstppr added a commit that referenced this pull request Aug 16, 2021
@shwstppr
Volume migration fix wrt#22(#27)
e7030a7
* fix worker vm
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* remove unwanted logs
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@github-actions

github-actionsBot commented Apr 8, 2022

Copy link
Copy Markdown

Hi @dependabot[bot], your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?

@yadvryadvr closed this Apr 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandDaanHoogland left review comments
@nvazqueznvazqueznvazquez left review comments
@anuragawanuragawAwaiting requested review from anuragaw
@borisstoyanovborisstoyanovAwaiting requested review from borisstoyanov

Assignees

@dhlalukudhlaluku

Labels

new featurestatus:has-conflicts

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dhlaluku@borisstoyanov@DaanHoogland@nvazquez@yadvr