support for multidisk OVA files by abhinandanprateek · Pull Request #7 · shapeblue/cloudstack

abhinandanprateek · 2017-03-20T13:26:00Z

Signed-off-by: Abhinandan Prateek abhinandan.prateek@shapeblue.com

borisstoyanov · 2017-03-21T11:43:05Z

@abhinandanprateek shouldn't this be in the Interoute repo? Can you please move the PR there?

abhinandanprateek · 2017-03-21T11:53:28Z

@borisstoyanov AFAIK other than the two FR that @rhtyd is working on, others need to go to master cc @PaulAngus

borisstoyanov · 2017-03-21T12:35:47Z

I see @DaanHoogland has created the PR for FR2.6 in the Interoute repo as well, is there any concerns with submitting the PRs from the interoute repo?

Actually what's the strategy on the community submissions? Where do we create PRs and how do we submit them in community?
cc: @rhtyd @PaulAngus @DaanHoogland

yadvr · 2017-04-12T12:34:42Z

@abhinandanprateek @borisstoyanov /cc @PaulAngus

I've implemented the following UI, where in case of multi-disk template (ova) you'll see options to select the disk offering for the data disk template:

Though this will take away the option to deploy additional data disk with the template. The UI code sort of existed already in the wizard, I found this today and made some changes to the API and the UI to reuse the widget which is a list of checkbox with labels (the data disk name) and the list of disk offerings per data disk.

The params will be passed to the API as follows:

yadvr · 2017-04-12T12:36:09Z

Additional note: this may need some refining as it does not make sense to me to select a disk offering that has a fixed size where the data disk (template) might already have a fixed size?

borisstoyanov · 2017-04-18T06:30:45Z

Hi guys, looks like there are conflicts in the data schema, can we resolve them before jumping into testing please? @abhinandanprateek @rhtyd

borisstoyanov · 2017-04-19T06:25:08Z

Hi guys tried building the PR but build failed with

[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:43.636s
[INFO] Finished at: Wed Apr 19 06:17:41 UTC 2017
[INFO] Final Memory: 113M/1448M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project cloud-vmware-base: Compilation failure: Compilation failure:
[ERROR] /jenkins/workspace/shapeblue-centos6-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.10.0.0-SNAPSHOT/vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java:[164,15] error: cannot find symbol
[ERROR] symbol: variable UUID
[ERROR] location: class HypervisorHostHelper
[ERROR] /jenkins/workspace/shapeblue-centos6-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.10.0.0-SNAPSHOT/vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java:[1662,34] error: cannot find symbol
[ERROR] symbol: variable UUID
[ERROR] location: class HypervisorHostHelper
[ERROR] /jenkins/workspace/shapeblue-centos6-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.10.0.0-SNAPSHOT/vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java:[1772,16] error: cannot find symbol
[ERROR] symbol: class FileWriter
[ERROR] location: class HypervisorHostHelper
[ERROR] /jenkins/workspace/shapeblue-centos6-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.10.0.0-SNAPSHOT/vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java:[1772,37] error: cannot find symbol
[ERROR] -> [Help 1]
[ERROR]

http://build.yadav.xyz:8080/job/shapeblue-pkg-builder/60/
Is this related to the removal of midonet plugin?
@abhinandanprateek @rhtyd

yadvr · 2017-04-19T07:07:30Z

Yes @borisstoyanov I've sent a PR to fix the master/upstream issue

yadvr · 2017-04-20T05:40:27Z

+ importSpecParams.setEntityName(importEntityName);
+ importSpecParams.setDeploymentOption("");
+
+ String ovfDescriptor = removeOVFNetwork(HttpNfcLeaseMO.readOvfContent(ovfFilePath));


@abhinandanprateek I've made this additional change

Signed-off-by: Abhinandan Prateek <abhinandan.prateek@shapeblue.com>

…lti-disk

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

…ootable disk info

…nt permissions.

…lates in UI

…ptop while does not when build on jenkins,

…e details

DaanHoogland · 2017-06-13T06:37:05Z

@abhinandanprateek Did you merge back master? I think you better rebase, instead. This is going to look messy.

abhinandanprateek · 2017-06-13T10:52:41Z

@DaanHoogland heard ya

abhinandanprateek · 2017-06-13T12:12:42Z

moved to community.

…via the VPC VR if it is gateway

Fix various linting warnings and errors in resource and basic layout component. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This implements a work-in-progress VM deployment wizard. Co-authored-by: Rohit Yadav <rohit@apache.org> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

abhinandanprateek force-pushed the md-ova branch from 2d7efd5 to 1dde0e2Compare April 18, 2017 07:01

yadvr force-pushed the md-ova branch from 6b9f775 to e03b95aCompare April 20, 2017 05:31

yadvr changed the base branch from master to 4.9April 20, 2017 05:36

yadvr changed the base branch from 4.9 to masterApril 20, 2017 05:36

yadvr reviewed Apr 20, 2017
View reviewed changes

abhinandanprateek force-pushed the md-ova branch 4 times, most recently from d60e160 to 69b96a3Compare April 27, 2017 08:25

abhinandanprateek force-pushed the md-ova branch 4 times, most recently from 9960c45 to 42710caCompare May 8, 2017 08:09

abhinandanprateekand others added 9 commits May 24, 2017 15:40

support for multidisk OVA files
60f5bc2
Signed-off-by: Abhinandan Prateek <abhinandan.prateek@shapeblue.com>

adding list of child templates to listTemplates for templates with mu…
f532eae
…lti-disk

md-ova: implement diskoffering selections for data disks
c2f0e8e
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

remove original ovf with the boot template, generate a new one with b…
9aa6f2f
…ootable disk info

fix the template diretcory permission as ova file may have inconsiste…
9c3c3e8
…nt permissions.

md-ove: moving querying and creation of data disk template to SSVM
e1d73a7

md-ova: attach iso if that is part of the ova package
9ca10db

md-ova: for disk offering limit the list to only child data disk temp…
db77261
…lates in UI

md-ova: need to revisit this fix, this test throws exception on my la…
4e963ca
…ptop while does not when build on jenkins,

abhinandanprateek force-pushed the md-ova branch 4 times, most recently from 025ff2c to 896b29bCompare May 26, 2017 07:07

md-ova: get disk controllers from ovf file and set them up in templat…
12071c4
…e details

abhinandanprateek force-pushed the md-ova branch from 896b29b to 12071c4Compare May 26, 2017 08:33

abhinandanprateek force-pushed the md-ova branch from 6670db7 to 453fe8bCompare June 7, 2017 07:06

md-ova: ISO metadata fix
5962519

abhinandanprateek force-pushed the md-ova branch 2 times, most recently from 961ce01 to bb23562Compare June 10, 2017 05:35

md-ov: resize disk as per service offering
bf71fc5

abhinandanprateek force-pushed the md-ova branch from 6f70007 to 019898eCompare June 12, 2017 11:44

md-ova: ui chanegs if there is no attached datadisk
80c50bd

abhinandanprateek force-pushed the md-ova branch from 019898e to 80c50bdCompare June 12, 2017 12:12

md-ova: template sizes could be null
ebc848d

abhinandanprateek force-pushed the md-ova branch from 5db84c4 to ebc848dCompare June 13, 2017 03:10

Merge branch 'master' into md-ova
025c901

abhinandanprateek closed this Jun 13, 2017

Pearl1594 pushed a commit that referenced this pull request Nov 25, 2020
bugfix#7vpc vr: allow servers in private gateway to reach internet …
a8c9b45
…via the VPC VR if it is gateway

yadvr pushed a commit that referenced this pull request Jan 20, 2021
Fix eslint errors (#7)
1e05b89
Fix various linting warnings and errors in resource and basic layout component. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added a commit that referenced this pull request Jan 20, 2021
compute: work-in-progress VM deployment wizard (#7)
ef189ce
This implements a work-in-progress VM deployment wizard. Co-authored-by: Rohit Yadav <rohit@apache.org> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Navigation Menu

Uh oh!

support for multidisk OVA files - #7

support for multidisk OVA files#7
abhinandanprateek wants to merge 15 commits into
masterfrom
md-ova

abhinandanprateek commented Mar 20, 2017

Uh oh!

borisstoyanov commented Mar 21, 2017

Uh oh!

abhinandanprateek commented Mar 21, 2017

Uh oh!

borisstoyanov commented Mar 21, 2017

Uh oh!

yadvr commented Apr 12, 2017

Uh oh!

yadvr commented Apr 12, 2017

Uh oh!

borisstoyanov commented Apr 18, 2017

Uh oh!

borisstoyanov commented Apr 19, 2017

Uh oh!

yadvr commented Apr 19, 2017

Uh oh!

yadvrApr 20, 2017

Uh oh!

DaanHoogland commented Jun 13, 2017

Uh oh!

abhinandanprateek commented Jun 13, 2017

Uh oh!

abhinandanprateek commented Jun 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

abhinandanprateek commented Mar 20, 2017

Uh oh!

borisstoyanov commented Mar 21, 2017

Uh oh!

abhinandanprateek commented Mar 21, 2017

Uh oh!

borisstoyanov commented Mar 21, 2017

Uh oh!

yadvr commented Apr 12, 2017

Uh oh!

yadvr commented Apr 12, 2017

Uh oh!

borisstoyanov commented Apr 18, 2017

Uh oh!

borisstoyanov commented Apr 19, 2017

Uh oh!

yadvr commented Apr 19, 2017

Uh oh!

yadvrApr 20, 2017

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jun 13, 2017

Uh oh!

abhinandanprateek commented Jun 13, 2017

Uh oh!

abhinandanprateek commented Jun 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants