Skip to content

Fix python 3.9 and 3.8 error - #62

Open
josesaranda wants to merge 1 commit into
masterfrom
fix/python_3.8_and_3.9_installation
Open

Fix python 3.9 and 3.8 error#62
josesaranda wants to merge 1 commit into
masterfrom
fix/python_3.8_and_3.9_installation

Conversation

@josesaranda

Copy link
Copy Markdown

This MR fixes khiva-python dll location for python 3.9 version

@josesarandajosesaranda self-assigned this Jul 27, 2021

@avilchessavilchess left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesaranda
josesaranda removed the request for review from daniram9July 27, 2021 12:43
@codecov

codecovBot commented Jul 27, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.65%. Comparing base (891622c) to head (2ed40b0).

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #62 +/- ##
==========================================
- Coverage 84.84% 84.65% -0.19% 
==========================================
Files 14 14 Lines 1597 1597 ==========================================
- Hits 1355 1352 -3 - Misses 242 245 +3 
FlagCoverage Δ
Linux?
MacOS?
Windows84.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
khiva/library.py84.37% <100.00%> (-3.13%)⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891622c...2ed40b0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@josesaranda@avilchess