Uh oh!
There was an error while loading. Please reload this page.
Visvalingam runs on both 64 and 32 floats. - #169
Open
justoruiz wants to merge 2 commits into
Open
Conversation
daniram9
previously approved these changes
Sep 3, 2021
justoruiz
marked this pull request as draft
September 3, 2021 09:01
justoruiz
marked this pull request as ready for review
September 3, 2021 09:02
daniram9
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Visvalingam now runs transparently for float64 and float32 types.
Tests
Added DimensionalityTests.VisvalingamAF to test both scenarios.
Benchmarks
N/A