Uh oh!
There was an error while loading. Please reload this page.
Add linting - #79
Merged
Merged
Conversation
This change adds linting through `eslint`, with config read across from [ShareDB][1] [1]: share/sharedb#302
coveralls
commented
Jul 18, 2019
alecgibson
commented
Jul 18, 2019
ContributorAuthor
(Coverage decrease is because the linting has increased the number of lines in some places) |
ericyhwang
approved these changes
Jul 31, 2019
ericyhwang
left a comment
Contributor
There was a problem hiding this comment.
LGTM from me and Nate, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds linting through
eslint, with config read across fromShareDB