Uh oh!
There was an error while loading. Please reload this page.
Do not compose create with op - #213
Conversation
The problem is that the `create` operation contains initial data rather than a snapshot and `apply` requires the first param to be a snapshot. So, the original implementation worked only for the types which have the same type of initial data and snapshots.
ericyhwang
commented
Jul 11, 2018
From the PR review meeting, @gkubisa linked #214 as an example of where this can cause an issue, with the custom text-tp2 OT type. @nateps's comments:
Greg suggests, if we do want to keep the performance benefit, adding an @nateps says that after talking about it, let's just merge this. |
gkubisa
commented
Jul 12, 2018
Just to clarify, I agree with @nateps that the performance impact of this change is negligible. I mentioned |
curran
commented
Jul 22, 2020
Suggest to close as stale. |
The problem is that the
createoperation contains initial data rather than a snapshot andapplyrequires the first param to be a snapshot. So, the original implementation worked only for the types which have the same type of initial data and snapshots.