Make whenNothingPending always async

[gkubisa]

See #204 (comment)

[coveralls]

Coverage increased (+0.003%) to 95.906% when pulling fe1b7c0 on Teamwork:fix-whenNothingPending into 5394fa4 on share:master.

[curran]

Looks good to me aside from some duplicated logic!

Also to clarify the motivation for this PR, I'm guessing it's the following statement by @ericyhwang from #204 (comment)

Code should always be async (e.g. process.nextTick) or always be sync, not both.

and

Remove the sync workaround, make a separate PR for making whenNothingPending async consistently.

[gkubisa]

@ericyhwang , could this PR be merged now?

[curran]

Looks good! Thanks for making that change removing the duplicated logic.

There seems to be a meaningful test case removed (see inline comment).

[curran]

Looks good to merge! /cc @ericyhwang

[curran]

@gkubisa This change looks good, but unfortunately now has merge conflicts.

@ericyhwang I think this would be a nice improvement. In fact I just ran into issues around this async behavior today.

[gkubisa]

This PR has been already open for over 9 months, so I have very little motivation to keep it up to date with the master branch. It's already merged into the Teamwork fork of ShareDB.

[curran]

Understood. It's unfortunate that this good work has not gotten the attention it deserves.

[ericyhwang]

Ah, I lost track of this, sorry - my email notification routing for the Share org wasn't properly set up at that point.

I'll do some integration testing on my end, and if that all checks out, we can get it merged tomorrow.

[curran]

Potentially this nextTick can be removed

sharedb/lib/client/connection.js

Line 583 in 5394fa4

process.nextTick(function(){

Although, it's unrelated because it's on the connection. This could be a separate PR.

[ericyhwang]

LGTM from Nate during PR review meeting, apologies for dropping the ball!

[ericyhwang]

This is published as sharedb@1.0.0-beta.22