Skip to content

Update example in README.md to use @teamwork/websocket-json-stream - #276

Merged
ericyhwang merged 1 commit into
share:masterfrom
Teamwork:teamwork-websocket-json-stream
Mar 7, 2019
Merged

Update example in README.md to use @teamwork/websocket-json-stream#276
ericyhwang merged 1 commit into
share:masterfrom
Teamwork:teamwork-websocket-json-stream

Conversation

@gkubisa

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.85% when pulling 31be02e on Teamwork:teamwork-websocket-json-stream into 02187ca on share:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.85% when pulling 31be02e on Teamwork:teamwork-websocket-json-stream into 02187ca on share:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.85% when pulling 31be02e on Teamwork:teamwork-websocket-json-stream into 02187ca on share:master.

@ericyhwangericyhwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Before I merge, the example's otherwise fine with you?

Side note - I checked with Nate quickly, and when updating examples, he actually started on improving the client's handling of certain websocket libraries. Not directly related to the server websocket library.

@gkubisa

Copy link
Copy Markdown
ContributorAuthor

Yes, it looks good to me.

@ericyhwang
ericyhwang merged commit 17de0fd into share:masterMar 7, 2019
@gkubisa
gkubisa deleted the teamwork-websocket-json-stream branch March 7, 2019 07:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gkubisa@coveralls@ericyhwang