Uh oh!
There was an error while loading. Please reload this page.
Reduce tolerance for nanoseconds - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens DispatchTimer’s default scheduling tolerance for .nanoseconds intervals and adds unit tests to lock in the new behavior, alongside updating the CI workflow environment.
Changes:
- Update
DispatchTimer.defaultTolerance(_:)so positive.nanosecondsintervals map to.nanoseconds(0)(and non-positive remain.never). - Add new XCTest cases covering
defaultTolerancebehavior for.nanosecondsand.never. - Update GitHub Actions CI runner / checkout version / Xcode selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Sources/DispatchTimer/DispatchTimer.swift | Changes default tolerance handling for .nanoseconds and adjusts extension visibility to enable testing. |
Tests/DispatchTimerTests/DispatchTimerTests.swift | Adds coverage for default tolerance behavior and updates Linux allTests. |
.github/workflows/ci.yml | Changes macOS runner, updates checkout action, and pins an Xcode selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.