Uh oh!
There was an error while loading. Please reload this page.
Do not listen to lifecycle events on Mac Catalyst - #60
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes lifecycle event observation functionality for the SQLiteDatabase class and adds conditional compilation to prevent app lifecycle notifications from being registered on Mac Catalyst.
- Removes
observeLifecycleEventsparameter from database initialization methods - Updates conditional compilation to exclude Mac Catalyst from UIKit-based lifecycle handling
- Always calls
registerForAppNotifications()without conditional logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
atdrendel
commented
Sep 24, 2025
@myobie I merged your pull request. Then, after pulling that change into the iOS app, I thought to myself, when would anyone ever want to listen to those lifecycle events on Mac Catalyst? So, I figured I'd just remove them here inside of SQLite and remove the need for the extra argument and compilation condition inside of our iOS app. |
Uh oh!
There was an error while loading. Please reload this page.
No description provided.