Create Elektra specification file - #829
Conversation
markus2330
left a comment
There was a problem hiding this comment.
Please provide example for each key, it makes the spec much easier to read. Also plenty of defaults are missing.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
qwepoizt
commented
Jul 22, 2021
I've added examples and defaults. |
qwepoizt
commented
Jul 22, 2021
I've incorporated all your suggestions! |
markus2330
commented
Jul 22, 2021
Can you also add CLI arguments/env vars (if needed) before I review it again? |
qwepoizt
commented
Jul 23, 2021
Yes, I have now added CLI arguments! I haven't found any usage of env vars in redshift. I also made some other minor improvements. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
markus2330
commented
Jul 24, 2021
They are now 😉 Please change the top-post to contain an instruction for reviewers. |
qwepoizt
commented
Jul 29, 2021
Thanks, I did! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
… which automatically picks a suitable option
qwepoizt
commented
Aug 5, 2021
I believe this is ready to be merged into 814-improve-config as a first step of #814 |
markus2330
commented
Sep 10, 2021
I think this can be closed now as it is superseded by #837? |
qwepoizt
commented
Sep 11, 2021
Yes, I agree! |
This PR adds an Elektra specification file for redshift (#814).
Reviewers, please take a look at the names of configuration settings.