Skip to content

🎨 Palette: Fix clear annotation link behavior - #591

Open
sheepdestroyer wants to merge 4 commits into
masterfrom
fix-clear-annotation-link-8863069444126633097
Open

🎨 Palette: Fix clear annotation link behavior#591
sheepdestroyer wants to merge 4 commits into
masterfrom
fix-clear-annotation-link-8863069444126633097

Conversation

@sheepdestroyer

@sheepdestroyersheepdestroyer commented Aug 25, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced the <a href="#"> clear annotation action with a native <button type="button"> that looks identical.
🎯 Why: Clicking the href="#" link would cause the page to jump to the top, which was disorienting when reviewing datasets down the page.
📸 Before/After: Visuals are identical, but behavior is fixed.
♿ Accessibility: Better semantic HTML by using a button for a JS action rather than a link.


PR created automatically by Jules for task 8863069444126633097 started by @sheepdestroyer

Summary by Sourcery

Use a semantically appropriate button for clearing annotations without changing the control’s visual appearance.

Bug Fixes:

  • Prevent clearing annotations from jumping the page to the top by using a native button for the action.

Enhancements:

  • Improve the semantic accessibility of the annotation-clearing control while preserving its existing appearance.

Chores:

  • Record the guidance for replacing hash links used for JavaScript actions with buttons.

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-aiBot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The clear annotation control now uses a native button instead of an href="#" link, preventing unwanted page jumps and improving semantic accessibility while retaining the existing appearance and behavior.

File-Level Changes

ChangeDetailsFiles
Replace the clear-annotation link with a semantically correct button while preserving its visual appearance.
  • Use button type="button" for the JavaScript clear action.
  • Apply inline styles to retain the link-like red, underlined presentation.
  • Keep the existing annotation index and clearAnnotation click handler unchanged.
router/static/visualizer.html
Document the usability and accessibility lesson behind the control change.
  • Record that href="#" can unexpectedly move the page to the top.
  • Recommend native buttons with styling resets for JavaScript actions.
.Jules/palette.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitaiBot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b9124c59-2575-4eeb-bb37-d03309119403


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation router labels Aug 25, 2026

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

google-labs-julesBotand others added 3 commits August 25, 2026 05:24
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationrouter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sheepdestroyer