🎨 Palette: Replace anchor tags with semantic buttons & add input ARIA labels - #592
🎨 Palette: Replace anchor tags with semantic buttons & add input ARIA labels#592sheepdestroyer wants to merge 1 commit into
Conversation
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR updates the review annotation UI to use semantically appropriate controls: the clear action is now a styled button that avoids anchor navigation side effects, and the note input is explicitly labeled for screen readers. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What:
Replaced the
<a href="#">used for clearing annotations with a semantic<button type="button">styled as a link, and added anaria-labelto the review note input.🎯 Why:
Using
<a href="#">for JavaScript actions causes unintended page jumps to the top and is semantically incorrect for non-navigational actions. The input field was missing an accessible label for screen readers.📸 Before/After:
Before: The "clear" action used an anchor tag (
<a href="#">), and the note input relied purely on visual placeholders.After: The "clear" action uses a
<button>tag maintaining the exact visual look, and the input hasaria-label="Review note".♿ Accessibility:
aria-labelfor the text input, satisfying WCAG criteria for labeled controls.PR created automatically by Jules for task 1550057290398253083 started by @sheepdestroyer
Summary by Sourcery
Improve review annotation controls with accessible semantics and labeled input fields.
Bug Fixes:
Enhancements:
Chores: