Skip to content

🎨 Palette: Replace anchor tags with semantic buttons & add input ARIA labels - #592

Open
sheepdestroyer wants to merge 1 commit into
masterfrom
palette-visualizer-ux-1550057290398253083
Open

🎨 Palette: Replace anchor tags with semantic buttons & add input ARIA labels#592
sheepdestroyer wants to merge 1 commit into
masterfrom
palette-visualizer-ux-1550057290398253083

Conversation

@sheepdestroyer

@sheepdestroyersheepdestroyer commented Aug 25, 2026

Copy link
Copy Markdown
Owner

💡 What:
Replaced the <a href="#"> used for clearing annotations with a semantic <button type="button"> styled as a link, and added an aria-label to the review note input.

🎯 Why:
Using <a href="#"> for JavaScript actions causes unintended page jumps to the top and is semantically incorrect for non-navigational actions. The input field was missing an accessible label for screen readers.

📸 Before/After:
Before: The "clear" action used an anchor tag (<a href="#">), and the note input relied purely on visual placeholders.
After: The "clear" action uses a <button> tag maintaining the exact visual look, and the input has aria-label="Review note".

♿ Accessibility:

  • Improved keyboard and screen reader semantics by using a native button instead of a dummy link.
  • Provided a descriptive aria-label for the text input, satisfying WCAG criteria for labeled controls.

PR created automatically by Jules for task 1550057290398253083 started by @sheepdestroyer

Summary by Sourcery

Improve review annotation controls with accessible semantics and labeled input fields.

Bug Fixes:

  • Prevent unintended page jumps when clearing annotations by replacing the dummy anchor action with a semantic button.

Enhancements:

  • Improve accessibility of the review interface with a labeled note input and proper button semantics while preserving the clear action’s link-like appearance.

Chores:

  • Record guidance on avoiding anchor tags for JavaScript-only actions.

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-aiBot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates the review annotation UI to use semantically appropriate controls: the clear action is now a styled button that avoids anchor navigation side effects, and the note input is explicitly labeled for screen readers.

File-Level Changes

ChangeDetailsFiles
Improved semantics and accessibility of annotation controls.
  • Added a descriptive ARIA label to the review note input.
  • Replaced the JavaScript-only clear link with a native button while preserving its link-like appearance and behavior.
  • Recorded the accessibility implementation guidance in the project palette notes.
router/static/visualizer.html
.Jules/palette.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f6c7c7e-fa88-4073-88dc-5b364594cd32


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation router labels Aug 25, 2026

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationrouter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sheepdestroyer