Skip to content

⚡ Bolt: Optimize cache eviction with islice - #594

Open
sheepdestroyer wants to merge 1 commit into
masterfrom
bolt-optimize-cache-eviction-6442362511399972285
Open

⚡ Bolt: Optimize cache eviction with islice#594
sheepdestroyer wants to merge 1 commit into
masterfrom
bolt-optimize-cache-eviction-6442362511399972285

Conversation

@sheepdestroyer

@sheepdestroyersheepdestroyer commented Aug 25, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced list(triage_cache.keys())[:excess] with list(itertools.islice(triage_cache.keys(), excess)) for LRU cache eviction.
🎯 Why: Avoids materializing all keys in memory when evicting elements, saving memory on large caches.
📊 Impact: O(1) memory overhead during eviction instead of O(N) where N is the cache size.
🔬 Measurement: Observe memory footprint stability during mass triage evictions.


PR created automatically by Jules for task 6442362511399972285 started by @sheepdestroyer

Summary by Sourcery

Optimize triage cache eviction to avoid unnecessary memory allocation for large caches.

Enhancements:

  • Reduce memory usage during triage cache eviction by selecting only the excess oldest keys instead of materializing the full key set.

Chores:

  • Clean up unused imports and improve token-counting variable naming.

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d38b996-5b27-4adc-ae79-05306f1b6210


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-aiBot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR optimizes triage-cache eviction by limiting key materialization to the entries being evicted, reducing eviction-time temporary memory from O(N) to O(excess) while preserving LRU behavior; it also includes minor import and naming cleanup in router/main.py.

Flow diagram for memory-efficient triage cache eviction

flowchart TD
A["cleanup_triage_cache"] --> B["Calculate excess entries"]
B --> C{excess > 0}
C -- No --> D["Keep cache unchanged"]
C -- Yes --> E["itertools.islice(triage_cache.keys(), excess)"]
E --> F["Materialize only excess keys"]
F --> G["triage_cache.pop(k, None)"]
Loading

File-Level Changes

ChangeDetailsFiles
Reduce temporary memory use during LRU triage-cache eviction by slicing the key iterator instead of materializing the entire key list.
  • Use itertools.islice to select only the excess number of oldest keys before removal.
  • Retain the existing eviction order and excess-size logic.
router/main.py
Clean up incidental imports and local variable naming without changing behavior.
  • Rename the token-counting loop variable to avoid shadowing and improve readability.
  • Remove unused typing and validation imports.
  • Remove the redundant local json import.
router/main.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sheepdestroyer