🎨 Palette: Replace interactive anchor tag with accessible button in visualizer - #597
🎨 Palette: Replace interactive anchor tag with accessible button in visualizer#597sheepdestroyer wants to merge 3 commits into
Conversation
…isualizer Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR replaces the visualizer’s File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…isualizer Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
…isualizer Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
💡 What: Replaced the
<a href="#">element used for the 'clear' action with a<button type="button">element inrouter/static/visualizer.html. Added:focus-visibleCSS rules for the new button.🎯 Why: Using
<a href="#">for JS actions causes unintended scrolling to the top of the page when clicked and uses incorrect semantic markup. Using a native<button>ensures proper accessibility and expected keyboard interactions without visual disruption.📸 Before/After: Visual changes were checked with a screenshot and Playwright script. The visual style of the button remains exactly the same.
♿ Accessibility: Improved keyboard interaction and semantic HTML structure. The new button supports proper focus states with
:focus-visible.PR created automatically by Jules for task 6973127635797892123 started by @sheepdestroyer
Summary by Sourcery
Use an accessible native button for clearing visualizer annotations while preserving the existing visual design.
Bug Fixes:
Enhancements: