Skip to content

🎨 Palette: [UX improvement] Replace clear annotation link with button - #598

Open
sheepdestroyer wants to merge 4 commits into
masterfrom
palette-fix-clear-link-17861087334840072462
Open

🎨 Palette: [UX improvement] Replace clear annotation link with button#598
sheepdestroyer wants to merge 4 commits into
masterfrom
palette-fix-clear-link-17861087334840072462

Conversation

@sheepdestroyer

@sheepdestroyersheepdestroyer commented Aug 26, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced the <a href="#"> link used for clearing annotations with a semantically correct <button type="button"> element, styled to look like the original link.
🎯 Why: Using an anchor tag with href="#" for a JavaScript action causes an unintended scroll to the top of the page when clicked, which disrupts the user experience. A native <button> provides the correct semantics without the scrolling side effect.
📸 Before/After: Visuals remain identical (the button uses an inline CSS reset to look exactly like the previous link).
♿ Accessibility: Improves accessibility by using a <button> element for an action, rather than an anchor tag which is meant for navigation.


PR created automatically by Jules for task 17861087334840072462 started by @sheepdestroyer

Summary by Sourcery

Use a semantically correct button for clearing annotations without changing the existing visual presentation.

Bug Fixes:

  • Prevent page jumps when clearing annotations by replacing the JavaScript action link with a native button.

Enhancements:

  • Improve the semantics and accessibility of the annotation-clearing control while preserving its link-like appearance.

Chores:

  • Document the guidance to use buttons instead of hash links for JavaScript actions.

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-aiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR changes the annotation clear control from an href="#" anchor to a styled button that invokes the same JavaScript handler, eliminating unintended page scrolling while improving semantic accessibility; the rationale is also recorded in the project palette guidance.

File-Level Changes

ChangeDetailsFiles
Replace the annotation-clearing navigation link with a native button while preserving its link-like appearance and behavior.
  • Use <button type="button"> for the clear action to prevent hash-navigation scrolling and provide correct action semantics.
  • Apply inline styling to remove default button chrome and retain the existing red, underlined link presentation.
  • Keep the existing clearAnnotation(${idx}) click handler unchanged.
router/static/visualizer.html
Document the implementation guidance for JavaScript-only actions.
  • Record the accessibility and UX rationale for avoiding <a href="#"> in favor of styled buttons.
.Jules/palette.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation router labels Aug 26, 2026
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a236f82a-25c3-47c4-bfa7-a62e48e7b24b


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

google-labs-julesBotand others added 3 commits August 26, 2026 05:44
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationrouter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sheepdestroyer