🎨 Palette: [UX improvement] Replace clear annotation link with button - #598
🎨 Palette: [UX improvement] Replace clear annotation link with button#598sheepdestroyer wants to merge 4 commits into
Conversation
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR changes the annotation clear control from an File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
💡 What: Replaced the
<a href="#">link used for clearing annotations with a semantically correct<button type="button">element, styled to look like the original link.🎯 Why: Using an anchor tag with
href="#"for a JavaScript action causes an unintended scroll to the top of the page when clicked, which disrupts the user experience. A native<button>provides the correct semantics without the scrolling side effect.📸 Before/After: Visuals remain identical (the button uses an inline CSS reset to look exactly like the previous link).
♿ Accessibility: Improves accessibility by using a
<button>element for an action, rather than an anchor tag which is meant for navigation.PR created automatically by Jules for task 17861087334840072462 started by @sheepdestroyer
Summary by Sourcery
Use a semantically correct button for clearing annotations without changing the existing visual presentation.
Bug Fixes:
Enhancements:
Chores: