Skip to content

⚡ Bolt: [Cache annotations as raw bytes instead of parsed dict] - #600

Open
sheepdestroyer wants to merge 4 commits into
masterfrom
bolt-fast-cache-3458818378623777530
Open

⚡ Bolt: [Cache annotations as raw bytes instead of parsed dict]#600
sheepdestroyer wants to merge 4 commits into
masterfrom
bolt-fast-cache-3458818378623777530

Conversation

@sheepdestroyer

@sheepdestroyersheepdestroyer commented Aug 27, 2026

Copy link
Copy Markdown
Owner

💡 What: Changed _read_annotations_async to cache the raw bytes of the annotations file rather than a parsed dictionary. Replaced copy.deepcopy() with orjson.loads(cached_bytes).

🎯 Why: In Python, copy.deepcopy() on large dictionaries is extremely slow. By caching the raw bytes and parsing them via orjson.loads on every read, we create a fresh dictionary much faster than deep copying an existing one. This improves performance for endpoints reading annotations.

📊 Impact: Expected to reduce the time spent retrieving cached annotations significantly (e.g. 4.1s to 0.6s in benchmarks for 1000 items), improving endpoint response times for dashboard interactions.

🔬 Measurement: I ran a local benchmark script comparing 1000 iterations of copy.deepcopy() against orjson.loads(raw_bytes). The benchmark showed a speedup from ~4.13s to ~0.67s. Additionally, the test suite passes confirming functionality remains unchanged.


PR created automatically by Jules for task 3458818378623777530 started by @sheepdestroyer

Summary by Sourcery

Speed up cached annotation retrieval while preserving independent results for callers.

Enhancements:

  • Improve annotation reads by caching file contents as raw JSON bytes and parsing fresh results on demand, reducing the cost of copying large cached dictionaries.

Tests:

  • Update annotation read tests to validate binary file access, raw-byte caching, cache invalidation, and mutation isolation.

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-aiBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Reworks annotation caching to retain raw JSON bytes and parse them with orjson on every access, avoiding slow deep copies while preserving fresh, independently mutable results; tests and engineering guidance are updated accordingly.

Sequence diagram for raw-byte annotation cache reads

sequenceDiagram
participant Caller
participant Reader as _read_annotations_async
participant File as AnnotationFile
participant Cache as _annotations_cache
participant Parser as orjson.loads
Caller->>Reader: _read_annotations_async(path)
Reader->>File: stat(path)
alt cache miss or mtime changed
Reader->>File: open(path, rb)
File-->>Reader: content bytes
Reader->>Cache: store mtime and content
else cache hit
Reader->>Cache: read cached content
Cache-->>Reader: content bytes
end
Reader->>Parser: orjson.loads(content)
Parser-->>Reader: fresh annotation dict
Reader-->>Caller: annotation dict
Loading

File-Level Changes

ChangeDetailsFiles
Cache annotation files as raw UTF-8 bytes and deserialize fresh objects on each read.
  • Switch file reads from text mode to binary mode.
  • Store file bytes with the modification time instead of a parsed dictionary.
  • Use orjson.loads in a worker thread for both cache hits and misses, preserving caller isolation without copy.deepcopy.
  • Update cache and mutation-isolation tests for the byte-backed representation.
router/main.py
tests/test_read_annotations_async.py
Remove imports that became unused during the refactor.
  • Remove unused Pydantic validators and typing imports.
  • Remove local copy and json imports.
router/main.py
Document the raw-byte caching performance pattern.
  • Add guidance recommending raw JSON bytes plus parse-on-read instead of deep copying cached dictionaries.
.jules/bolt.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitaiBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 780a7c4f-262c-47d7-b1b5-f3ecff6726ac


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation router tests labels Aug 27, 2026

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

google-labs-julesBotand others added 3 commits August 27, 2026 05:19
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationroutertests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sheepdestroyer