🎨 Palette: [UX improvement] Replace clear annotation link with button - #601
🎨 Palette: [UX improvement] Replace clear annotation link with button#601sheepdestroyer wants to merge 1 commit into
Conversation
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe dataset visualizer now uses a native button for clearing annotations, eliminating the link’s unintended page-top navigation while preserving its appearance and improving action semantics for accessibility. Sequence diagram for clearing a dataset annotationsequenceDiagram
participant User
participant Visualizer
participant Browser
participant clearAnnotation
User->>Visualizer: Click clear button
Visualizer->>clearAnnotation: clearAnnotation(idx)
clearAnnotation-->>Visualizer: Annotation cleared
Note over Browser,Visualizer: No href navigation or page-top scroll
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
💡 What: Replaced the non-semantic
<a href="#">element with a native<button type="button">element for the "clear" annotation action in the dataset visualizer.🎯 Why: Using
<a href="#">causes the browser to unintentionally scroll to the top of the page when clicked. Using a semantic<button>prevents this unexpected jump, maintaining the user's context in the long list, while retaining the exact same visual appearance through inline CSS resets.📸 Before/After: Visual appearance is unchanged (inline styles replicate the link appearance).
♿ Accessibility: Improves semantics for screen readers by identifying an interactive action as a
buttonrather than a navigationlink.PR created automatically by Jules for task 9579450888416798936 started by @sheepdestroyer
Summary by Sourcery
Replace the annotation clear link with a semantically appropriate button to preserve user context and improve accessibility.
Bug Fixes:
Enhancements: