Skip to content

🎨 Palette: [UX improvement] Replace interactive anchor with semantic button - #602

Open
sheepdestroyer wants to merge 4 commits into
masterfrom
fix/ux-replace-interactive-anchor-14054697372291538011
Open

🎨 Palette: [UX improvement] Replace interactive anchor with semantic button#602
sheepdestroyer wants to merge 4 commits into
masterfrom
fix/ux-replace-interactive-anchor-14054697372291538011

Conversation

@sheepdestroyer

@sheepdestroyersheepdestroyer commented Aug 27, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced the interactive <a href="#"> for clearing annotations with a semantic <button type="button">.
🎯 Why: Clicking <a href="#"> tags forces an unintended scroll to the top of the page, disrupting the user experience. Using a semantically correct button prevents this page jump.
📸 Before/After: Visual appearance remains the same.
♿ Accessibility: Improved semantic markup and keyboard navigation.


PR created automatically by Jules for task 14054697372291538011 started by @sheepdestroyer

Summary by Sourcery

Replace the annotation-clearing link with an accessible button to prevent unintended navigation and improve interaction semantics.

Bug Fixes:

  • Prevent annotation clearing from causing an unintended page jump to the top.

Enhancements:

  • Use a semantically correct button for clearing annotations while preserving the existing link-like appearance and improving keyboard focus visibility.

Chores:

  • Record the accessibility and interaction guideline for replacing action anchors with buttons.

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-aiBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The annotation clear control now uses a native button instead of an href="#" anchor, preventing unintended scrolling while improving semantics and keyboard accessibility; styling preserves the existing link-like appearance and the rationale is documented.

File-Level Changes

ChangeDetailsFiles
Replace the annotation-clearing link with a semantically correct button while preserving its link-like appearance.
  • Use <button type="button"> for the clear action to avoid the anchor fragment navigation and page jump.
  • Retain visual styling through inline button resets and link-style text decoration.
  • Add an accessible label for the clear-review action.
router/static/visualizer.html
Document the implementation lesson for future interactive controls.
  • Record the accessibility and UX rationale for replacing interactive anchors with native buttons.
  • Document the styling requirements needed to preserve the existing appearance.
.Jules/palette.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation router labels Aug 27, 2026
@coderabbitai

coderabbitaiBot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1462482f-3186-4e86-93de-6d124fdebfe7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments### Comment 1
<locationpath="router/static/visualizer.html"line_range="328" />
<code_context>
<buttononclick="saveNote(${idx})">Save Note</button>
</div>
- ${ann ? `<div style="margin-top:8px;font-size:0.75em;color:#64b5f6">✓ Reviewed as <b>${escapeHtml(ann.tier)}</b> · <a href="#" onclick="clearAnnotation(${idx})" style="color:#f44336">clear</a></div>` : ''}+ ${ann ? `<div style="margin-top:8px;font-size:0.75em;color:#64b5f6">✓ Reviewed as <b>${escapeHtml(ann.tier)}</b> · <button type="button" onclick="clearAnnotation(${idx})" style="display: inline-block; width: auto; text-align: left; background: transparent; color: #f44336; border: none; font-family: inherit; font-size: inherit; padding: 0; cursor: pointer; text-decoration: underline;" aria-label="Clear review">clear</button></div>` : ''}
</div>
`;
</code_context>
<issue_to_address>
**issue (testing):** The existing end-to-end test still searches for `.human-review a`, but this change removes the only anchor and renders a button instead, so `test_visualizer_clear_annotation` fails at its visibility assertion before exercising the clear action.
**Triggers:** When the visualizer end-to-end test suite runs.
**Suggested fix:** Update the test locator to target the new button, such as `.human-review button[aria-label="Clear review"]`.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: router/static/visualizer.html:328


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment threadrouter/static/visualizer.html Outdated
<button onclick="saveNote(${idx})">Save Note</button>
</div>
${ann ? `<div style="margin-top:8px;font-size:0.75em;color:#64b5f6">✓ Reviewed as <b>${escapeHtml(ann.tier)}</b> · <a href="#" onclick="clearAnnotation(${idx})" style="color:#f44336">clear</a></div>` : ''}
${ann ? `<div style="margin-top:8px;font-size:0.75em;color:#64b5f6">✓ Reviewed as <b>${escapeHtml(ann.tier)}</b> · <button type="button" onclick="clearAnnotation(${idx})" style="display: inline-block; width: auto; text-align: left; background: transparent; color:#f44336; border: none; font-family: inherit; font-size: inherit; padding: 0; cursor: pointer; text-decoration: underline;" aria-label="Clear review">clear</button></div>` : ''}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (testing): The existing end-to-end test still searches for .human-review a, but this change removes the only anchor and renders a button instead, so test_visualizer_clear_annotation fails at its visibility assertion before exercising the clear action.

Triggers: When the visualizer end-to-end test suite runs.

Suggested fix: Update the test locator to target the new button, such as .human-review button[aria-label="Clear review"].

google-labs-julesBotand others added 3 commits August 27, 2026 05:32
…cus outline
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
…cus outline
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
…cus outline
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationrouter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sheepdestroyer