🛡️ Sentinel: [HIGH] Fix CRLF injection risk in proxy endpoints

[sheepdestroyer]

🚨 Severity: HIGH
💡 Vulnerability: The proxy_memory and proxy_audio endpoints accept a user-provided path to construct the downstream URL. Missing validation for carriage return (\r) and line feed (\n) characters could allow CRLF injection (HTTP Request Smuggling/Splitting) when passed to the downstream httpx client.
🎯 Impact: Attackers could potentially inject arbitrary HTTP headers or manipulate the downstream request routing.
🔧 Fix: Added \r and \n to the explicit blocklist for path validation in both proxy endpoints.
✅ Verification: Ran unit tests to ensure proxy endpoints still function correctly and block invalid paths.

---

PR created automatically by Jules for task 5886050546245768712 started by @sheepdestroyer

Summary by Sourcery

Prevent CRLF injection through the memory and audio proxy endpoints by rejecting paths containing carriage return or line feed characters.

Bug Fixes:

• Block carriage return and line feed characters in memory and audio proxy paths to prevent CRLF injection and downstream HTTP request manipulation.

Tests:

• Add coverage confirming both proxy endpoints reject CRLF-containing paths with HTTP 400 responses.

Chores:

• Record the CRLF injection vulnerability and prevention guidance in the Sentinel security notes.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's Guide

The PR hardens both proxy endpoints against CRLF injection by extending existing path validation to reject carriage-return and line-feed characters in both raw and cleaned paths, adds focused HTTP 400 regression tests, and documents the security lesson.

Sequence diagram for CRLF validation in proxy endpoints

sequenceDiagram
participant Client
participant ProxyEndpoint
participant HTTPX
participant Downstream
Client->>ProxyEndpoint: proxy_memory(request, path) or proxy_audio(request, path)
ProxyEndpoint->>ProxyEndpoint: Validate path and clean_path
alt CRLF detected
ProxyEndpoint-->>Client: HTTPException 400 Invalid path
else Path is valid
ProxyEndpoint->>HTTPX: Request downstream URL
HTTPX->>Downstream: Forward proxy request
Downstream-->>HTTPX: Response
HTTPX-->>ProxyEndpoint: Response
ProxyEndpoint-->>Client: Proxy response
end

Loading

File-Level Changes

Change	Details	Files
Block CRLF characters before constructing downstream proxy URLs.	Reject carriage-return and line-feed characters in both original and normalized paths. Return HTTP 400 for paths containing blocked control characters. Apply identical validation to memory and audio proxy endpoints.	router/main.py
Add regression coverage for CRLF injection attempts.	Test that memory proxy rejects a CRLF-containing path. Test that audio proxy rejects a CRLF-containing path. Assert rejected requests produce HTTP 400 errors.	router/tests/test_memory_proxy_crlf.py
Document the discovered vulnerability and prevention guidance.	Record the CRLF injection risk from unsanitized URL concatenation. Recommend blocking CRLF or using strict URL parsing for dynamic paths.	.jules/sentinel.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f5d9152b-0a5b-4131-9fdf-fe7b5e8e5fce

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

Sourcery withdrew this approval because the latest commits introduced blocking findings.

[sourcery-ai]

Sourcery assessment

Approved.