🎨 Palette: Improve accessibility in visualizer annotation tools - #607
🎨 Palette: Improve accessibility in visualizer annotation tools#607sheepdestroyer wants to merge 4 commits into
Conversation
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe annotation UI now uses semantically appropriate, explicitly non-submitting buttons for JavaScript actions, adds an accessible name for the note input, and preserves the existing visual styling while preventing hash-link page jumps. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
💡 What: Replaced
<a href="#">with a native<button type="button">for clearing annotations, addedaria-labelto the note input, and ensured the save button hastype="button".🎯 Why: Using
#links for JS actions causes the page to jump to the top when clicked, disrupting the user's flow. Buttons are semantically correct for actions. Added ARIA labels improve screen reader support.📸 Before/After: Visuals remain identical as the button was styled with inline resets to look like a link.
♿ Accessibility: Screen readers will now announce the inputs properly, and keyboard navigation behaves semantically correctly without scrolling the page.
PR created automatically by Jules for task 1456950515525397045 started by @sheepdestroyer
Summary by Sourcery
Improve visualizer annotation controls for accessible, predictable keyboard and screen-reader interaction.
Bug Fixes:
Enhancements:
Chores: