Skip to content

🎨 Palette: Improve accessibility in visualizer annotation tools - #607

Open
sheepdestroyer wants to merge 4 commits into
masterfrom
palette/a11y-visualizer-tools-1456950515525397045
Open

🎨 Palette: Improve accessibility in visualizer annotation tools#607
sheepdestroyer wants to merge 4 commits into
masterfrom
palette/a11y-visualizer-tools-1456950515525397045

Conversation

@sheepdestroyer

@sheepdestroyersheepdestroyer commented Aug 28, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced <a href="#"> with a native <button type="button"> for clearing annotations, added aria-label to the note input, and ensured the save button has type="button".
🎯 Why: Using # links for JS actions causes the page to jump to the top when clicked, disrupting the user's flow. Buttons are semantically correct for actions. Added ARIA labels improve screen reader support.
📸 Before/After: Visuals remain identical as the button was styled with inline resets to look like a link.
♿ Accessibility: Screen readers will now announce the inputs properly, and keyboard navigation behaves semantically correctly without scrolling the page.


PR created automatically by Jules for task 1456950515525397045 started by @sheepdestroyer

Summary by Sourcery

Improve visualizer annotation controls for accessible, predictable keyboard and screen-reader interaction.

Bug Fixes:

  • Prevent annotation clearing from jumping the visualizer to the top by using a semantic button instead of an empty anchor.

Enhancements:

  • Improve annotation tool accessibility with semantic controls, descriptive labels, and explicit non-submit button types while preserving the existing visual appearance.

Chores:

  • Document the accessibility guidance for replacing empty anchors used for JavaScript actions.

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-aiBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The annotation UI now uses semantically appropriate, explicitly non-submitting buttons for JavaScript actions, adds an accessible name for the note input, and preserves the existing visual styling while preventing hash-link page jumps.

File-Level Changes

ChangeDetailsFiles
Correct interactive control semantics and keyboard behavior for annotation actions.
  • Replaced the hash link used to clear annotations with a native button that invokes the existing handler without causing page navigation.
  • Applied inline button resets and link-like styling to preserve the existing visual presentation.
router/static/visualizer.html
Improve accessible naming and explicit button behavior in the annotation form.
  • Added an accessible label to the review-note text input.
  • Declared the save control as a non-submitting button.
router/static/visualizer.html
Document the accessibility lesson behind the implementation.
  • Recorded guidance to prefer native buttons for JavaScript actions and preserve appearance with CSS resets.
.Jules/palette.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitaiBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ded67a7-d561-45ad-b42d-1285f3c27346


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation router labels Aug 28, 2026

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

google-labs-julesBotand others added 3 commits August 28, 2026 05:28
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationrouter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sheepdestroyer