🎨 Palette: [UX improvement] Enhance accessibility and fix page jump on clear action - #609
🎨 Palette: [UX improvement] Enhance accessibility and fix page jump on clear action#609sheepdestroyer wants to merge 1 commit into
Conversation
…n clear action Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR improves annotation controls by replacing the page-jumping hash link with an accessible button, adding accessible naming and explicit button semantics to the review-note UI, and documenting the pattern for future changes. Sequence diagram for accessible annotation clearingsequenceDiagram
actor Reviewer
participant Visualizer
Reviewer->>Visualizer: Click clear button
Visualizer->>Visualizer: clearAnnotation(idx)
Visualizer-->>Reviewer: Annotation cleared without page jump
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
💡 What: Changed the 'clear' annotation link to a semantic button with an ARIA label, and added an ARIA label to the note input field.
🎯 Why: Clicking the previous
<a href="#">clear link caused the page to unexpectedly jump to the top. Changing it to a<button>fixes this interaction while CSS resets maintain its visual appearance. Adding ARIA labels improves screen reader compatibility for the form controls.📸 Before/After: Visuals remain unchanged; functionality is smoother.
♿ Accessibility: Added
aria-labelto icon-only/inline actions and text inputs. Replaced semantic links with buttons for JS actions.PR created automatically by Jules for task 14341377501335738262 started by @sheepdestroyer
Summary by Sourcery
Improve annotation controls to provide accessible semantics and smoother clearing interactions.
Bug Fixes:
Enhancements: