Skip to content

🎨 Palette: [UX improvement] Enhance accessibility and fix page jump on clear action - #609

Open
sheepdestroyer wants to merge 1 commit into
masterfrom
jules-ux-accessibility-fix-14341377501335738262
Open

🎨 Palette: [UX improvement] Enhance accessibility and fix page jump on clear action#609
sheepdestroyer wants to merge 1 commit into
masterfrom
jules-ux-accessibility-fix-14341377501335738262

Conversation

@sheepdestroyer

@sheepdestroyersheepdestroyer commented Aug 28, 2026

Copy link
Copy Markdown
Owner

💡 What: Changed the 'clear' annotation link to a semantic button with an ARIA label, and added an ARIA label to the note input field.
🎯 Why: Clicking the previous <a href="#"> clear link caused the page to unexpectedly jump to the top. Changing it to a <button> fixes this interaction while CSS resets maintain its visual appearance. Adding ARIA labels improves screen reader compatibility for the form controls.
📸 Before/After: Visuals remain unchanged; functionality is smoother.
♿ Accessibility: Added aria-label to icon-only/inline actions and text inputs. Replaced semantic links with buttons for JS actions.


PR created automatically by Jules for task 14341377501335738262 started by @sheepdestroyer

Summary by Sourcery

Improve annotation controls to provide accessible semantics and smoother clearing interactions.

Bug Fixes:

  • Prevent page jumps when clearing annotations by using a button for the JavaScript action instead of a hash link.

Enhancements:

  • Improve accessibility of annotation controls with semantic buttons and descriptive ARIA labels for the clear action and review note input.

…n clear action
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: be521ef7-8cfb-4250-9b70-4f02b8cba5ec


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-aiBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR improves annotation controls by replacing the page-jumping hash link with an accessible button, adding accessible naming and explicit button semantics to the review-note UI, and documenting the pattern for future changes.

Sequence diagram for accessible annotation clearing

sequenceDiagram
actor Reviewer
participant Visualizer
Reviewer->>Visualizer: Click clear button
Visualizer->>Visualizer: clearAnnotation(idx)
Visualizer-->>Reviewer: Annotation cleared without page jump
Loading

File-Level Changes

ChangeDetailsFiles
Replace the annotation clear link with a semantic, visually link-like button to prevent page jumps during JavaScript actions.
  • Use a button with explicit button type and accessible name for clearing annotations.
  • Apply inline CSS resets and link styling to preserve the existing appearance.
router/static/visualizer.html
Improve accessible naming and native control semantics in the annotation form.
  • Add an ARIA label to the review note input.
  • Declare the Save Note control as a non-submitting button.
router/static/visualizer.html
Document the accessibility and interaction pattern for future palette changes.
  • Record guidance to use buttons for JavaScript actions and preserve link-like styling with CSS resets.
.Jules/palette.md
Update repository ignore configuration.
  • Add the new ignore entry.
.gitignore

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation router labels Aug 28, 2026

@sourcery-aisourcery-aiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationrouter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sheepdestroyer