🛡️ Sentinel: [CRITICAL] Fix hardcoded test secrets in responses API

[sheepdestroyer]

🚨 Severity: CRITICAL
💡 Vulnerability: The responses_api endpoint allowed bypassing proper authorization in production using hardcoded development/test tokens like gateway-pass or test-key.
🎯 Impact: An attacker could use these known test tokens to access backend AI models unauthenticated, bypassing proper rate limits, and potentially inflating billing or exhausting rate limits for the service.
🔧 Fix: The test tokens have been restricted to only load into the valid_keys list if pytest is currently running. Otherwise, in a production environment, they are safely excluded.
✅ Verification: Ran the router's test suite to ensure no tests were broken since they continue to have access to these tokens.

---

PR created automatically by Jules for task 6072292353613489706 started by @sheepdestroyer

Summary by Sourcery

Restrict responses API test credentials to test environments to enforce production authentication.

Bug Fixes:

• Prevent production use of hardcoded test credentials to access the responses API without authorization.

Enhancements:

• Keep test-only credentials available during pytest runs while restricting production authentication to configured secrets.

Chores:

• Document the vulnerability and prevention guidance for the responses API authorization keys.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR removes hardcoded test tokens from production authorization by injecting them into the responses API allowlist only when pytest is loaded, while retaining environment-configured keys and documenting the vulnerability and prevention guidance.

Sequence diagram for responses API token authorization

sequenceDiagram
participant Client
participant ResponsesAPI
participant Environment
participant Pytest
Client->>ResponsesAPI: POST /v1/responses with client_token
ResponsesAPI->>Environment: Read ROUTER_API_KEY, LITELLM_MASTER_KEY, GATEWAY_KEY
alt pytest is loaded
ResponsesAPI->>Pytest: Check pytest in sys.modules
ResponsesAPI->>ResponsesAPI: Add hardcoded test keys to valid_keys
else production runtime
ResponsesAPI->>ResponsesAPI: Exclude hardcoded test keys from valid_keys
end
alt client_token in valid_keys
ResponsesAPI-->>Client: Process request
else invalid or missing token
ResponsesAPI-->>Client: HTTP 401 Unauthorized
end

Loading

File-Level Changes

Change	Details	Files
Restrict hardcoded test authorization tokens to pytest-only execution.	Detect pytest via sys.modules before defining test tokens. Keep production validation limited to configured environment secrets while preserving test access.	router/main.py
Document the security vulnerability and preventive guidance.	Record the authorization-key exposure, impact, and mitigation. Recommend environment-based secret configuration and test-only credential injection.	.jules/sentinel.md
Update repository ignore configuration.	Add the generated or task-specific Jules content to ignore rules.	.gitignore

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e7f87b5-598a-4396-970a-071fc8d3c672

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. This changes the authorization decision by allowing known hardcoded tokens whenever the running process has pytest loaded; if that condition occurs in a deployed service, anyone with those tokens could gain access. Reverting stops the behavior going forward, but any unauthorized access during the window cannot be undone.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}