🎨 Palette: Replace link with semantic button for clear action - #612
🎨 Palette: Replace link with semantic button for clear action#612sheepdestroyer wants to merge 4 commits into
Conversation
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR makes the annotation-clearing control a semantic button instead of a hash link, preventing unintended page scrolling and improving accessibility while preserving the existing visual style; it also documents the pattern and updates ignore rules. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
💡 What: Replaced the
<a href="#">tag for clearing annotations with a semantic<button type="button">.🎯 Why: Clicking
<a href="#">: causes unintended scrolling to the top of the page. Using a button provides correct semantics for an interactive action.📸 Before/After: Visual appearance is preserved with inline CSS resets.
♿ Accessibility: Improves semantics for screen readers and avoids confusing scroll behavior.
PR created automatically by Jules for task 4415222548332674915 started by @sheepdestroyer
Summary by Sourcery
Use a semantic button for clearing annotations to prevent unintended scrolling and improve accessibility.
Bug Fixes:
Enhancements:
Chores: