🎨 Palette: Improve interactive element accessibility - #613
🎨 Palette: Improve interactive element accessibility#613sheepdestroyer wants to merge 4 commits into
Conversation
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideImproves interactive accessibility by using explicit button semantics for visualizer actions, eliminating page jumps when clearing annotations, and adding descriptive screen-reader labels to dashboard links that open in new tabs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments### Comment 1
<locationpath="router/templates/dashboard.html"line_range="855" />
<code_context>
<divclass="btn-group">
<!-- Goose Dashboard local -->- <a href="https://t.me/SheepBot?start=goose" target="_blank" rel="noopener noreferrer" class="btn" style="background: rgba(251, 191, 36, 0.05); border-color: rgba(251, 191, 36, 0.2);" aria-describedby="new-tab-desc">+ <a href="https://t.me/SheepBot?start=goose" target="_blank" rel="noopener noreferrer" class="btn" style="background: rgba(251, 191, 36, 0.05); border-color: rgba(251, 191, 36, 0.2);" aria-describedby="new-tab-desc" aria-label="Open Goose Telegram Bot in new tab"> <span>{{ src_badge("GOOSE", "#fbbf24") | safe }} <span aria-hidden="true">🦢</span> Goose Telegram Bot</span> <span class="btn-arrow" aria-hidden="true">→</span>
</code_context>
<issue_to_address>
**nitpick (bug_risk):** Each link's accessible name already says "in new tab" while `aria-describedby` separately appends "(opens in a new tab)", so screen readers announce the new-tab instruction twice.
**Triggers:** When a screen reader encounters any of the four updated dashboard links.
**Suggested fix:** Remove "in new tab" from each `aria-label`, or remove the redundant `aria-describedby` reference.
</issue_to_address>Sourcery assessment
Approved.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <div class="btn-group"> | ||
| <!-- Goose Dashboard local --> | ||
| <a href="https://t.me/SheepBot?start=goose" target="_blank" rel="noopener noreferrer" class="btn" style="background: rgba(251, 191, 36, 0.05); border-color: rgba(251, 191, 36, 0.2);" aria-describedby="new-tab-desc"> | ||
| <a href="https://t.me/SheepBot?start=goose" target="_blank" rel="noopener noreferrer" class="btn" style="background: rgba(251, 191, 36, 0.05); border-color: rgba(251, 191, 36, 0.2);" aria-describedby="new-tab-desc" aria-label="Open Goose Telegram Bot in new tab"> |
There was a problem hiding this comment.
nitpick (bug_risk): Each link's accessible name already says "in new tab" while aria-describedby separately appends "(opens in a new tab)", so screen readers announce the new-tab instruction twice.
Triggers: When a screen reader encounters any of the four updated dashboard links.
Suggested fix: Remove "in new tab" from each aria-label, or remove the redundant aria-describedby reference.
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
💡 What: Replaced clear annotation
<a>tag with native<button>and addedtype="button"attributes in the visualizer. Added descriptivearia-labels to dashboard link buttons.🎯 Why: Fixes page jump when clearing annotations and improves screen reader support for console links.
📸 Before/After: N/A (no visible changes).
♿ Accessibility: Improved keyboard navigation on interactive elements and enhanced screen reader context.
PR created automatically by Jules for task 7853348159379244494 started by @sheepdestroyer
Summary by Sourcery
Improve accessibility and interaction behavior across the visualizer and dashboard controls.
Bug Fixes:
Enhancements:
Chores: