Stringifier Ignores Manually Added Func Child Nodes

[jonathantneal]

• Webpack Version: N/A
• Operating System (or Browser): N/A
• Node Version: N/A
• postcss-values-parser Version: 3.0.1

How Do We Reproduce?

Insert a new node into an AST.

import valuesParser from 'postcss-values-parser';
import Punctuation from 'postcss-values-parser/lib/nodes/Punctuation';

const astValue = valuesParser.parse('rgb(100% 100% 100%)');

astValue.nodes[0].nodes.splice(1, 0, new Punctuation({ value: ',' }));
astValue.nodes[0].nodes.splice(2, 0, new Punctuation({ value: ',' }));

console.log({
	punctuation: valuesParser.nodeToString(astValue.nodes[0].nodes[1]),
	root: valuesParser.nodeToString(astValue)
});

Expected Behavior

Commas are added.

{
 punctuation: ',\n',
 root: 'rgb(100%, 100%, 100%)'
}

Actual Behavior

Commas are not added.

{
 punctuation: ',\n',
 root: 'rgb(100% 100% 100%)'
}

[shellscape]

Very strange. We're not deviating or overwriting how PostCSS's nodes behave in that regard.

[jonathantneal]

The issue is that Func is stringified by its params and not by its nodes.

astValue.nodes[0].params = 'NODES ARE IGNORED';

console.log({
	root: valuesParser.nodeToString(astValue) // "rgbNODES ARE IGNORED"
});

[shellscape]

Yeah, here's the culprit:

postcss-values-parser/lib/ValuesStringifier.js

Line 28 in 8106956

this.builder(node.name + node.params, node, 'start');

[jonathantneal]

As you intend it, is params to be a sugary getter/setter (i.e. parse/nodeToString) of nodes, or should params be available at all?

[shellscape]

It was intended to give a snapshot of the function sans name. This was 100% a lack of foresight on my part. Currently working on a fix for that.