Remove dependency on is-url-superb - #123
Conversation
shellscape
commented
Aug 17, 2020
Thanks for taking the initiative here. I'm not keen on adding additional code to maintain. I know it's a simple function, but that means it needs tests and such as well. I'd much rather use a package that had its own tests that I didn't have to maintain. |
I think adding tests here could be worth the price of avoiding a situation like this from happening again. I think only the protocol-relative URLs condition branch needs to be tested. What do you think? |
Another issue is that CI fails because package depends on itself (on an outdated version, Idk if intentionally). I see it's imported for performance tests. Would you have any suggestion on how to sort out this one? |
…plementation, with custom support for protocol-relative urls
This was used to allow imporing in performance tests. This fork will not concern with those.
davilima6
commented
Aug 18, 2020
Moving PR to draft while we don't have an alternative for 089a196 |
shellscape
commented
Sep 16, 2020
Closing in favor of #125. As noted on your other PR, I do sincerely and truthfully appreciate the work you put in on this. |
Addresses the proposed fix in #120 by providing a custom Node
URL-based implementation forisUrl.This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes